quic: retire read-closed streams on FIN

Previously, after closing the receive side of a stream locally, we
ignored incoming STREAM frames and waited for a RESET_STREAM in reply to
our STOP_SENDING. Per RFC 9000 Section 3.5, however, a peer that has
already sent FIN (Data Sent) may wait for its packets to be acknowledged
rather than sending RESET_STREAM, reaching Data Recvd without ever
resetting. Because we still acknowledged those packets while dropping
the STREAM frames, the receive side never retired, leaking stream state,
holding its MAX_STREAMS slot indefinitely, and never returning
connection-level MAX_DATA credit for those bytes.

For golang/go#70914

Change-Id: I3ccf83cf9c645c50f52beb091250a87f6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/net/+/864420
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>
3 files changed
tree: 3d3dc564323b07afa944a90136f7b8ec5f0162e7
  1. bpf/
  2. context/
  3. dict/
  4. dns/
  5. html/
  6. http/
  7. http2/
  8. icmp/
  9. idna/
  10. internal/
  11. ipv4/
  12. ipv6/
  13. lif/
  14. nettest/
  15. netutil/
  16. proxy/
  17. publicsuffix/
  18. quic/
  19. route/
  20. trace/
  21. webdav/
  22. websocket/
  23. xsrftoken/
  24. .gitattributes
  25. .gitignore
  26. codereview.cfg
  27. CONTRIBUTING.md
  28. go.mod
  29. go.sum
  30. LICENSE
  31. PATENTS
  32. README.md
README.md

Go Networking

Go Reference

This repository holds supplementary Go networking packages.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/net.

The main issue tracker for the net repository is located at https://go.dev/issues. Prefix your issue with “x/net:” in the subject line, so it is easy to find.