commit 53aca9bc7128b7c0cd513163c5432481f12025ee
author Mohamed Amin JABRI <amin.jabri@gmail.com> Wed Feb 24 17:36:34 2016 +0900
committer Mohamed Amin JABRI <amin.jabri@gmail.com> Wed Feb 24 17:36:34 2016 +0900
tree 544a9dff10acb9a99a72372a850d2da36e43e41a
parent c5b80ff1acd56407b295a5bcb8a2a69d8c87c48e

Pass const State to Fixture::TearDown. Fix memory leak in fixture_test

include/benchmark/benchmark_api.h

diff --git a/include/benchmark/benchmark_api.h b/include/benchmark/benchmark_api.h
index 0c5115d..7a42025 100644
--- a/include/benchmark/benchmark_api.h
+++ b/include/benchmark/benchmark_api.h
@@ -491,11 +491,11 @@
     virtual void Run(State& st) {
       this->SetUp(st);
       this->BenchmarkCase(st);
-      this->TearDown();
+      this->TearDown(st);
     }
 
     virtual void SetUp(const State&) {}
-    virtual void TearDown() {}
+    virtual void TearDown(const State&) {}
 
 protected:
     virtual void BenchmarkCase(State&) = 0;

test/fixture_test.cc

diff --git a/test/fixture_test.cc b/test/fixture_test.cc
index 92fbc4c..bf800fd 100644
--- a/test/fixture_test.cc
+++ b/test/fixture_test.cc
@@ -6,14 +6,18 @@
 
 class MyFixture : public ::benchmark::Fixture {
  public:
-  void SetUp(const ::benchmark::State&) {
-    assert(data.get() == nullptr);
-    data.reset(new int(42));
+  void SetUp(const ::benchmark::State& state) {
+    if (state.thread_index == 0) {
+      assert(data.get() == nullptr);
+      data.reset(new int(42));
+    }
   }
 
-  void TearDown() {
-    assert(data.get() != nullptr);
-    data.release();
+  void TearDown(const ::benchmark::State& state) {
+    if (state.thread_index == 0) {
+      assert(data.get() != nullptr);
+      data.reset();
+    }
   }
 
   ~MyFixture() {
@@ -32,10 +36,17 @@
 }
 
 BENCHMARK_DEFINE_F(MyFixture, Bar)(benchmark::State& st) {
+  if (st.thread_index == 0) {
+    assert(data.get() != nullptr);
+    assert(*data == 42);
+  }
   while (st.KeepRunning()) {
+    assert(data.get() != nullptr);
+    assert(*data == 42);
   }
   st.SetItemsProcessed(st.range_x());
 }
 BENCHMARK_REGISTER_F(MyFixture, Bar)->Arg(42);
+BENCHMARK_REGISTER_F(MyFixture, Bar)->Arg(42)->ThreadPerCpu();
 
 BENCHMARK_MAIN()

test/map_test.cc

diff --git a/test/map_test.cc b/test/map_test.cc
index 8d5f6ec..58399c1 100644
--- a/test/map_test.cc
+++ b/test/map_test.cc
@@ -36,7 +36,7 @@
     m = ConstructRandomMap(st.range_x());
   }
 
-  void TearDown() {
+  void TearDown(const ::benchmark::State&) {
     m.clear();
   }