Guard adding intel compiler flag behind check for intel compiler. (#2004)
* Guard adding intel compiler flag behind check for intel compiler.
For reasons I don't yet fully understand, failing to guard the check
for flag -wd654 will cause it to be added to certain clang
configurations, and then cause compilation to fail.
While exactly why this happens needs investigation, the fix
proposed in this patch seems direct and simple enough to
apply regardless.
* Update CMakeLists.txt
Address review comments by reusing intel compiler block.
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 219b151..b573ead 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -216,6 +216,9 @@
# See #631 for rationale.
add_cxx_compiler_flag(-wd1786)
add_cxx_compiler_flag(-fno-finite-math-only)
+ # ICC17u2: overloaded virtual function "benchmark::Fixture::SetUp" is only partially
+ # overridden (because of deprecated overload)
+ add_cxx_compiler_flag(-wd654)
endif()
# Disable deprecation warnings for release builds (when -Werror is enabled).
if(BENCHMARK_ENABLE_WERROR)
@@ -230,9 +233,7 @@
add_cxx_compiler_flag(-Wstrict-aliasing)
endif()
endif()
- # ICC17u2: overloaded virtual function "benchmark::Fixture::SetUp" is only partially overridden
- # (because of deprecated overload)
- add_cxx_compiler_flag(-wd654)
+
add_cxx_compiler_flag(-Wthread-safety)
if (HAVE_CXX_FLAG_WTHREAD_SAFETY)
cxx_feature_check(THREAD_SAFETY_ATTRIBUTES "-DINCLUDE_DIRECTORIES=${PROJECT_SOURCE_DIR}/include")
