| commit | a79eeb4d4fd60e5593e3540a0a4a0f6be83c1497 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Fri Aug 29 13:55:23 2025 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 03 21:21:54 2025 -0700 |
| tree | 9fc03934b8f93c2ebc702bcaa575e676d29065f0 | |
| parent | c08d7ba0f32bfca9f1705766449ce5f83b5a1b41 [diff] |
Make ASN1_EXTERN_FUNCS's parse callback CBS-based Having to keep flipping back and forth between the calling conventions when bridging rewritten types is tedious. This does not rewrite the core of tasn_dec.cc (although at this point much of it is already CBS-based), but it does suggest a calling convention for it. Right now, the internal calling convention is the double-pointer thing from d2i, with an extra twist that functions must return 0 for error, 1 for success, and -1 for "success but parsed nothing". This proposes a CBS in/out param to return how bytes we consumed, and a plain success/error return value. The -1 case can be modeled as successfully consuming zero bytes. For now, we still have to bridge the two inside tasn_dec.cc. Also for this CL I have not yet rewritten the messy X509_NAME parser, or the tasn_dec.cc parser. There's also a messy situation where this object sometimes is called with an existing object already there, and sometimes without one. I don't see a good way to avoid that one, but hopefully it'll become less and as important as we stop using the tasn system. Bug: 42290418 Change-Id: I3969e19ade81aedf449b4baf139fe5f5b1dd867b Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/81776 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: