Switch STACK_OF(T) back to std::sort from std::stable_sort

https://boringssl-review.googlesource.com/c/boringssl/+/91687 switched
STACK_OF(T)'s sorting to a stable sort after a recently-added test
exhibited some bugs depending on the sort order.

What was actually going on was that the test made some incorrect
assumptions on how X509_STORE behaved surrounding AKIDs, etc.
https://boringssl-review.googlesource.com/c/boringssl/+/91787 fixed the
test to be less sensitive to this.

std::stable_sort is more likely to allocate and thus depend on the C++
runtime. We do want to allow the C++ runtime in libcrypto, but there are
some hurdles to clear on Android first, so switch back to std::sort.
(At a glance through output on godbolt, libc++'s std::sort might
actually be header-only!)

This does mean that, with the wrong sort order,
X509StoreGet1IssuerMultipleMatches might test against the wrong
baseline. To prevent an unlikely false positive, remove the baselining
check. With the baseline check removed, the test will never have a false
positive, but we might have a false negative. I.e. we might fail to flag
a bug when it should. However, given the number of name collisions we
put in there, and the number of different platforms and STLs we test
against, this is unlikely. (Also that code should be rewritten to use a
hash table anyway.)

Change-Id: I1cca217ac713dbe7758fd4c102d901fdb6ebe177
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/95327
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Lily Chen <chlily@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
4 files changed
tree: 0591117dd651a593c26e522956991e18ecdce327
  1. .bcr/
  2. .github/
  3. bench/
  4. cmake/
  5. crypto/
  6. decrepit/
  7. docs/
  8. fuzz/
  9. gen/
  10. include/
  11. infra/
  12. pki/
  13. rust/
  14. ssl/
  15. third_party/
  16. tool/
  17. util/
  18. .bazelignore
  19. .bazelrc
  20. .bazelversion
  21. .clang-format
  22. .clang-format-ignore
  23. .clangd
  24. .gitattributes
  25. .gitignore
  26. API-CONVENTIONS.md
  27. AUTHORS
  28. BREAKING-CHANGES.md
  29. BUILD.bazel
  30. build.json
  31. BUILDING.md
  32. CMakeLists.txt
  33. codereview.settings
  34. CONTRIBUTING.md
  35. FUZZING.md
  36. go.mod
  37. go.sum
  38. INCORPORATING.md
  39. LICENSE
  40. MODULE.bazel
  41. MODULE.bazel.lock
  42. PORTING.md
  43. PRESUBMIT.py
  44. PrivacyInfo.xcprivacy
  45. README.md
  46. SANDBOXING.md
  47. SECURITY.md
  48. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: