Google Git
Sign in
pigweed / third_party / github / google / boringssl / d41763c049ff390c2a9c118645008d9216382ef1
commitd41763c049ff390c2a9c118645008d9216382ef1[log] [tgz]
authorDavid Benjamin <davidben@google.com>Thu Sep 25 09:17:59 2025 -0400
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 25 08:56:28 2025 -0700
treeb221f049c69478ef973a2090721e03372cd44d44
parenta34ea4da91402cb24e635da0b5d755fb0086fd97 [diff]
Make the ASN1_TYPE-level type take precedence over the ASN1_STRING one

It is not very difficult to get an ASN1_TYPE that is self-inconsistent,
where the ASN1_TYPE-level type says one thing and the ASN1_STRING-level
type says another.

In particular, a not entirely unreasonable caller pattern used in
Android does this when filling in X509_ALGOR parameters. The old
ASN1_TYPE encoder took the ASN1_TYPE type, but the new one takes the
ASN1_STRING type.

Match the old behavior. We probably should also make ASN1_TYPE_set0
internally fix the type of the ASN1_STRING, but I haven't done that
here. I think, either way, we should restore the old behavior of using
the outer type. With the mess of exposed types and ambiguous APIs in
OpenSSL, it's not too hard to manually construct something invalid here.

Bug: 446993031
Change-Id: Idd5c0356769d8ff9a034222a9ffc107ce7c6f02e
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/82187
Reviewed-by: Lily Chen <chlily@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
2 files changed
tree: b221f049c69478ef973a2090721e03372cd44d44
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .gitignore
  22. API-CONVENTIONS.md
  23. AUTHORS
  24. BREAKING-CHANGES.md
  25. BUILD.bazel
  26. build.json
  27. BUILDING.md
  28. CMakeLists.txt
  29. codereview.settings
  30. CONTRIBUTING.md
  31. FUZZING.md
  32. go.mod
  33. go.sum
  34. INCORPORATING.md
  35. LICENSE
  36. MODULE.bazel
  37. MODULE.bazel.lock
  38. PORTING.md
  39. PrivacyInfo.xcprivacy
  40. README.md
  41. SANDBOXING.md
  42. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: