tree 5e87c07b0b8650377be834b00d4d54d9a8520bea
parent 05ff000a47f874a9856a6ca07af07fda4c056b48
author David Benjamin <davidben@google.com> 1758229844 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> 1758410584 -0700

Reject explicit default X.509 versions and empty extension lists

X.509 version fields are declared as DEFAULT v1 which means, in DER, an
explicitly encoded version is invalid.

X.509 extension fields are declared as [3] EXPLICIT Extensions OPTIONAL
and Extensions ::= SEQUENCE SIZE (1..MAX) OF Extension.

This means in both BER and DER, the extensions list can never be empty.
Instead, a certificate or CRL with no extensions is supposed to be
encoded by omitting the OPTIONAL extensions field.

Also apply the version and extension checks to CRL entries, which we'd
missed earlier. All these checks are done by libpki.

Update-Note: X509 and X509_CRL parsers are now more spec-compliant and
reject some invalid inputs. After cl/809456844, internal tests have
passed with this change. The change was also validated with cl/800872048
and cl/802241042. Let us know if this encounters problems.

Fixed: 42290225, 442221114
Change-Id: I9a10d76ebb258f297079fc4d77b9eaf63f60b6c4
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/82087
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Auto-Submit: David Benjamin <davidben@google.com>