tree 799530d09acae04f88f190cd43f041fec0b6efe8
parent 389cb68b87193358358ae87cc56d257fd0d80189
author Krystian Kuzniarek <krystian.kuzniarek@gmail.com> 1609682692 +0100
committer Krystian Kuzniarek <krystian.kuzniarek@gmail.com> 1609682692 +0100

remove explicit function overloads of CmpHelper?? for BiggestInt arguments

Affects macros {ASSERT|EXPECT}_{EQ|NE|LE|LT|GE|GT}.

According to removed comments, these overloads were supposed to reduce
code bloat and allow anonymous enums on GCC 4.

However, the way it works on GCC 4 and the latest GCC (10.2 by now) is
that having:

template <typename T1, typename T2>
void foo(T1, T2);

using BiggestInt = long long;
void foo(BiggestInt, BiggestInt);

the template version takes precedence for almost every combination of
integral types except for two long long integers - i.e. implicit
promotion to long long is a worse match than generating a specific
template function.

Tested on GCC 4.8.1 (as GoogleTest requires C++11 and this was
the first C++11 feature-complete release of GCC),
GCC 4.8.5 (last of 4.8.x series) and the latest GCC (10.2.0).