commit | b86bf840d1d562d12efd4e0790ce14455f5fa271 | [log] [tgz] |
---|---|---|
author | Tanzinul Islam <tanzinul.islam@gmail.com> | Sun Sep 03 15:39:19 2023 +0100 |
committer | Tanzinul Islam <t_17_7@hotmail.com> | Sun Sep 03 16:46:02 2023 +0100 |
tree | e21a6f38eb396f8e229c70e78cfc80721ea459b9 | |
parent | 8a6feabf04bec8fb125e0df0ad1195c42350725f [diff] |
Count threads after thread-creation while still holding mutex lock The `Mutex` is locked with the `MutexLock` before spawning the thread, so that the thread is prevented from completing (by being blocked on `Mutex`) before the new thread count is obtained. However, the existing bug (introduced in 22e6055) releases `Mutex` before obtaining the new thread count, which allows the thread to run to completion in the meantime. Also, since the `(thread_count_after_create != starting_count + 1)` condition (line 328) skips the remainder of the `for`-loop body on every iteration, `thread_count_after_join` stays uninitialized. I believe this is why [this test failed][1] on the macOS CI with this trace: ``` [----------] 1 test from GetThreadCountTest [ RUN ] GetThreadCountTest.ReturnsCorrectValue googletest/test/googletest-port-test.cc:350: Failure Expected equality of these values: thread_count_after_create Which is: 1 starting_count + 1 Which is: 2 googletest/test/googletest-port-test.cc:351: Failure Expected equality of these values: thread_count_after_join Which is: 140493185949400 starting_count Which is: 1 [ FAILED ] GetThreadCountTest.ReturnsCorrectValue (2 ms) [----------] 1 test from GetThreadCountTest (2 ms total) ``` [1]: https://github.com/google/googletest/actions/runs/6064919420/job/16453860690?pr=3049
GoogleTest now follows the Abseil Live at Head philosophy. We recommend updating to the latest commit in the main
branch as often as possible. We do publish occasional semantic versions, tagged with v${major}.${minor}.${patch}
(e.g. v1.14.0
).
Our documentation is now live on GitHub Pages at https://google.github.io/googletest/. We recommend browsing the documentation on GitHub Pages rather than directly in the repository.
Release 1.14.0 is now available.
The 1.14.x branch requires at least C++14.
We use Google's internal systems for continuous integration.
GitHub Actions were added for the convenience of open-source contributors. They are exclusively maintained by the open-source community and not used by the GoogleTest team.
This repository is a merger of the formerly separate GoogleTest and GoogleMock projects. These were so closely related that it makes sense to maintain and release them together.
See the GoogleTest User's Guide for documentation. We recommend starting with the GoogleTest Primer.
More information about building GoogleTest can be found at googletest/README.md.
GoogleTest follows Google's Foundational C++ Support Policy. See this table for a list of currently supported versions of compilers, platforms, and build tools.
In addition to many internal projects at Google, GoogleTest is also used by the following notable projects:
GTest Runner is a Qt5 based automated test-runner and Graphical User Interface with powerful features for Windows and Linux platforms.
GoogleTest UI is a test runner that runs your test binary, allows you to track its progress via a progress bar, and displays a list of test failures. Clicking on one shows failure text. GoogleTest UI is written in C#.
GTest TAP Listener is an event listener for GoogleTest that implements the TAP protocol for test result output. If your test runner understands TAP, you may find it useful.
gtest-parallel is a test runner that runs tests from your binary in parallel to provide significant speed-up.
GoogleTest Adapter is a VS Code extension allowing to view GoogleTest in a tree view and run/debug your tests.
C++ TestMate is a VS Code extension allowing to view GoogleTest in a tree view and run/debug your tests.
Cornichon is a small Gherkin DSL parser that generates stub code for GoogleTest.
Please read CONTRIBUTING.md
for details on how to contribute to this project.
Happy testing!