commit 5ef10c9ea3c32e95cfe90257fbfce29f4160432f
author Kazuho Oku <kazuhooku@gmail.com> Sun Mar 21 15:03:50 2021 +0900
committer Kazuho Oku <kazuhooku@gmail.com> Sun Mar 21 15:03:50 2021 +0900
tree b1a4428a67687bf8ea422101d2ba54033e225c06
parent 77e007b88c33d749d9c9358c74724a0b53d3bd11

add comments

lib/openssl.c

diff --git a/lib/openssl.c b/lib/openssl.c
index 81336cf..9037b4e 100644
--- a/lib/openssl.c
+++ b/lib/openssl.c
@@ -705,14 +705,13 @@
 
 #if defined EVP_PKEY_ED25519
     if (EVP_PKEY_id(key) == EVP_PKEY_ED25519) {
+        /* ED25519 requires the use of the all-at-once function that appeared in OpenSSL 1.1.1, hence different path */
         if (EVP_DigestSign(ctx, NULL, &siglen, input.base, input.len) != 1) {
             ret = PTLS_ERROR_LIBRARY;
             goto Exit;
         }
-
         if ((ret = ptls_buffer_reserve(outbuf, siglen)) != 0)
             goto Exit;
-
         if (EVP_DigestSign(ctx, outbuf->base + outbuf->off, &siglen, input.base, input.len) != 1) {
             ret = PTLS_ERROR_LIBRARY;
             goto Exit;
@@ -1087,11 +1086,11 @@
 
 #if defined EVP_PKEY_ED25519
     if (EVP_PKEY_id(key) == EVP_PKEY_ED25519) {
+        /* ED25519 requires the use of the all-at-once function that appeared in OpenSSL 1.1.1, hence different path */
         if (EVP_DigestVerifyInit(ctx, &pkey_ctx, NULL, NULL, key) != 1) {
             ret = PTLS_ERROR_LIBRARY;
             goto Exit;
         }
-
         if (EVP_DigestVerify(ctx, signature.base, signature.len, data.base, data.len) != 1) {
             ret = PTLS_ERROR_LIBRARY;
             goto Exit;