tree 1fe1f656016cefb647c4d787c3cc911b6406517e
parent 11279616cf96c81d57542d5ddabc49d4ad79a0ac
author Jordan Bayles <bayles.jordan@gmail.com> 1781682709 -0700
committer GitHub <noreply@github.com> 1781682709 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJqMlIVCRC1aQ7uu5UhlAAAH+YQAGu6ZnZuuOR7wDf+WwgyPw1Y
 VoON54gmjrXuZ9bJBXEGMQzYTCCvwysWmsVd+mZR7MjJjICb4DxoM+ecvxxR0arr
 D9hWpBOpI8nW6xj492sdbuEA9VoCeizsjzH7kTxHrb3rE9aPGdbLNMJNE+18/9vc
 pShbGPg1tEBOH3aT/qjdnwNXd0sxRfSmvBIGIdqJbaitUHXMutXMFOt2jmyXp0sd
 h2q0sPvioPSG1NEsAJ8NiaSX6B8sX2vvrNCyfjf47pHuciUKVDPSBnGWHC9J0C8s
 4uTQIkQIwXsI5tYYJ/s4o0UA5Z1SvkjfirQ8j8bjE17dYSOeH8AmM6hsuBOSyFP5
 euCzfoMhCsJliwNW0wW83edL1NyqifpxBkqSeIoHV5r/N6ySoHVYomi1apINxcG0
 h3kwhhv5V4YXk9l9djNDsJ4+K9o+QxcJFHjbC2yhfJpvaS8UiinqrOo0I1wCbS3c
 RpSLCUg3cUuR28uSb4ff+nWfW3Fn9vUC2nphoc8CWvlZZECVUBFy/+QYlvtFvdPI
 jfA/ogWqCfAzcrQjGjvtaqRKdVan6dqBfm+xpE7cTyss/dhlUmtO3B8qXDmF8OdA
 GIHQtKKJk5VEXNTl6L/kQDk1st6Sm4lGMHnUA+DUJgmF1ovytC2BpuL517Nmwdpf
 2DDi3baXfCFabm4sQcIo
 =5/5J
 -----END PGP SIGNATURE-----
 

fix: allow a comment between a trailing comma and ']' (#1500) (#1696)

Trailing commas and comments are both allowed by default, but they did
not compose inside arrays: readArray detected a trailing-comma ']' with a
raw `*current_ == ']'` peek that skipped only whitespace, not comments.
So `[1, 2, /* c */]` left current_ at the comment, the peek failed, and
the parser tried to read another value -- which hit ']' and reported
"value, object or array expected". readObject already handled this via
readTokenSkippingComments.

Add skipCommentTokens() (skip whitespace and comments, leaving current_
at the next significant character) and use it in readArray before the
']' check. Consumed comments stay in commentsBefore_, so a comment before
a real element is still attached to it; if the array ends, they are
simply not attached -- matching object behavior.

Adds CharReaderTest/parseTrailingCommaWithComment covering line/block
comments after a trailing comma, an empty array containing only a
comment, the object form, and that a comment before a real element is
still attached.