tree a9a1d184e096f149e717461787b86be38c951d6b
parent 4bcbc6ac0509cc8b0d0d84618cfd518dd945c114
author Hong Xu <hong@topbug.net> 1762934826 -0800
committer GitHub <noreply@github.com> 1762934826 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJpFEAqCRC1aQ7uu5UhlAAAGZoQABRl3Q722+v0vk1E7Jvw3MZK
 fTbyuP/BqAWcGEsUcAVxHsipj1UjqtnfHpONxkg+NrGgo/TK4R32VDo8VyXhfFYN
 zzzI3F2grYNnwnnwaJI7Us4Jjg1fkhEJPBUkXzH6q2oXThnWcvdsJqqV2l/ixGZX
 WCI7cqRPAA5YD1HQmMwmJp/JcAqXUzsAUgCTrzncDL61HvEy7tm+RdzYdIZ5YbdF
 xZy4Xx0vLVTLmqGKgCIG2r1TBLMPZhY33X4QVtm2s2jfJ4yLb23sl8ajJJOnXEts
 EinYS4KjMTV5oRZCCtE8F/fXbflksxvVR8f+DhT8pdDntpzIRQ+eCj/4CpJJDrwA
 1ZnRn1txX69OiIiZ4L/2LuByAk9ya3UEQUhBIJM6f3Xb9qkF2JM1XEM6GoaygElp
 KVXcDOiMc5mm2/4IHvInwRmHqI4T8++odHj4ePXp8rgLNhHsnQTNDFi8dNOM3zdZ
 ZqxsORvCE1dAFyL8YNEyyxhKOD+9S5KHAuKBR9bjAJ80IUYTZr3WYtfIDNtobxdN
 P7h8rpEJXTY3L35/nh6uphy/eC6M/wUTaDFhgzKTXuTSt2t7EcZEA02+QgFn86y0
 cNfv0/Hjw1+eYxmExOyJfyeYC8r8SQ0KB+bSriyrzb+bP76Y6o9+rMauz3nyTi3Q
 HQiCjaxVVBdXYdvBi4T2
 =ZAwa
 -----END PGP SIGNATURE-----
 

Return false in Reader::readValue when stack limit is exceeded (#1619)

jsoncpp, as a shared library, should not call `abort` merely because there's an error reading a value.

See https://en.cppreference.com/w/c/program/abort, `abort` should only be called to **abnormally** cause the program to exit. Functions inserted by `atexit` are also not called, meaning that the host program may have not cleaned up resources properly. But here, exceeding stack limit isn't a sign of abnormalty.

`exit` is not a good substitute either, see the `exit-in-shared-library` from Debian:
https://lintian.debian.org/tags/exit-in-shared-library.html

Fix #1618

In this case, returning false seems like a better idea.

Co-authored-by: Jordan Bayles <bayles.jordan@gmail.com>