commit e1a3c64fef7351b49ad612c8b355a42666a7ff44
author vslashg <veloso@verylowsodium.com> Mon Sep 09 20:34:55 2024 -0400
committer GitHub <noreply@github.com> Mon Sep 09 17:34:55 2024 -0700
tree 2014c9e256c19ac5b804b1ad97cb1d846dceeaf8
parent 3c2205cd97838d3c4143107992967e23f0c958b8

Fix asserts in Value::setComment (#1445)

The existing asserts seem to not be what was intended; they appear to have been mistranslated in pull/877.

The first assert for `comment.empty()` was previously a check that a provided `const char*` parameter was not null.  The function this replaced accepted empty strings, and the if() statement at the start of this function handles them.

The second assert for `comment[0] == '\0'` was written when `comment` was a `const char*`, and was testing for empty c-string input.  This PR replaces it with `comment.empty()` to match the original intent.

Co-authored-by: Jordan Bayles <bayles.jordan@gmail.com>

src/lib_json/json_value.cpp

diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
index aa2b744..26cd843 100644
--- a/src/lib_json/json_value.cpp
+++ b/src/lib_json/json_value.cpp
@@ -1410,9 +1410,8 @@
     // Always discard trailing newline, to aid indentation.
     comment.pop_back();
   }
-  JSON_ASSERT(!comment.empty());
   JSON_ASSERT_MESSAGE(
-      comment[0] == '\0' || comment[0] == '/',
+      comment.empty() || comment[0] == '/',
       "in Json::Value::setComment(): Comments must start with /");
   comments_.set(placement, std::move(comment));
 }