tree 3caaaeee19a9deacf3394a2f0a3d76468f970520
parent cfbfe641f4f6056fe23441a7b29965fc454e8463
author Boris Zbarsky <bzbarsky@apple.com> 1683557381 -0400
committer GitHub <noreply@github.com> 1683557381 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJkWQwFCRBK7hj4Ov3rIwAAeEkIAFCyz1PXXioS3DPXmrTkd0Q9
 MAR8Ch+2rD4yg7i8PVJtlIkcyfaKpSYfDKYUxtMiq4V1fNCgaOOwp045F0ed5fSI
 /9VUfvlbY21WJu6peArzNoP9h9NKoDsx1M+HaUOtvPbrrY4FV6eORiQzrGvtLV+2
 kWyVkHL16LqXGuA4kjnndgYel1a4x/UyzoGJpFRZpQeMKf9yX9sRZFa03X/B0izj
 tC6UQApctOzNVkm48qC8e2XaYmQqCB+J3ikXWnNKwOzYtIZR4lNh13ICO1I+5q3z
 KdjtoSGeDyEKkh02g4SkU5sX0bDcFBMRfRESxNvJhiRlYANmDT4ZKI4eTcfJ4No=
 =5NnT
 -----END PGP SIGNATURE-----
 

Remove the OnSessionReleased callback from OperationalSessionSetup. (#26395)

Since OperationalSessionSetup is ephemeral, it only holds on to a session while
it's notifying its listeners, after which it will delete itself.

Right now it was deleting itself from OnSessionReleased, but that means it could
end up with a double-delete... and also, it's already notifying listeners if it
has a session, so there is no point, or ability, to notify them again on session
release.

The changes here:

1. Take out the OnSessionReleased that couldn't do anything except lead to
   use-after-free.
2. Fix a bug on OnSessionEstablished where if we got a session that's not usable
   we leaked and left our listeners hanging instead of just notifying our
   listeners with error.