tree 5d3508d016995a2aacefa60024fc3ce457bbbec3
parent 7611b99aa59b6b2ecca88196d6b62c186d70a007
author Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com> 1720972545 +1200
committer GitHub <noreply@github.com> 1720972545 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmk/UBCRC1aQ7uu5UhlAAA4AQQAG1suke/RpRx5Z477Q9kKAin
 axjVg/cIK5KbOt2OUbzBHQU3jxqiplZ5wPMb+yqCoSi+hIc/obUBTZVZF5FxRlGe
 ieqxWKUH3ym0ei2sh4d2jw8BqSWpk4uaTSUj+/4rJndxjDuiZa9M1rXbrhMIHF4h
 JtN0M1v+SNYSdiZPZMEr4rAjCP8O2uz4QQ3UERr00vG5CmcwX2pYgfBNCRiPwwxL
 jb/MGKKL1gJ+It+UiLUY+WB5SZeUD2eSpOCiliAd5HHrb2DNbpFcdYfl2IhTwDhX
 ZmVv7AwXsu8znaM8L4T4sOiYrn2+R6pntK2QWFJIHak+3RzSZnosjC8HKho6pXL5
 GH1O7c9aqYplFGoT7hGFJKqb2SGj1FjNzoD5d9oTuZesrKxkhnUthu8SYCppdVdH
 Im9A3U6KB7mGnVZiRCt8NEYXocIb0OCgrlQH4Nvg4iB3rUgcJs6YcE8yHOmDgkqU
 25RA5qv6wH99pKFcCWsICvzasKIU0fao5yym/ny1mJokJWih39GDU1RbR9GpUGrO
 tedlo1a8h94N2x+6MtBiQbKOsoFru3vAsQR6rlrCDg3P3sE3BTqat0HiAMZYCEx7
 7wQd6e5uYzkFfCOvj0mUgZmq/+o1TpuuwUnlf/m1tSL8v+n0xVWvFFiMfscOgOGR
 fpbO/AOf3WmxLfz1JW73
 =aLIJ
 -----END PGP SIGNATURE-----
 

Support raw ByteSpan values correctly in SafeAttributePersistenceProvider (#34306)

* Support raw ByteSpan values correctly in SafeattributePersistenceProvider

The DefaultAttributePersistenceProvider implementation of SafeReadValue() had
the undocumented behavior of enforcing that the value exactly filled the
provided buffer. This does not make sense for an API that purports to store
general ByteSpan values.

Instead move this validation into ReadScalarValue() in
SafeAttributePersistenceProvider, and separate InternalReadValue() into one
method that does the only the actual read, and a second one that performs the
additional validation for reading typed ember attributes (strings with length
prefixes etc). Use the former one from SafeReadValue().

Also fix possible out of bounds access when reading ember strings by ensuring
we have read the length byte(s) before attempting to interpret them.

* Take integral argument T by value

* Add test