Adding -Wformat-nonliteral check (#12763)
* Turn on -Wformat-security and -Wformat-nonliteral.
The ENFORCE_FORMAT annotations help make it clear to the compiler
which seemingly-nonliteral values are actually checked to be literals
further up the callstack, because we disallow passing a non-literal as
the format arg indicated by ENFORCE_FORMAT.
* Address review comments
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
diff --git a/src/app/tests/TestMessageDef.cpp b/src/app/tests/TestMessageDef.cpp
index 9451e20..95c3cd5 100644
--- a/src/app/tests/TestMessageDef.cpp
+++ b/src/app/tests/TestMessageDef.cpp
@@ -37,7 +37,9 @@
#include <lib/core/CHIPError.h>
#include <lib/core/CHIPTLVDebug.hpp>
#include <lib/support/CHIPMem.h>
+#include <lib/support/EnforceFormat.h>
#include <lib/support/UnitTestRegistration.h>
+#include <lib/support/logging/Constants.h>
#include <system/TLVPacketBufferBackingStore.h>
#include <nlunit-test.h>
@@ -46,7 +48,7 @@
using namespace chip::app;
-void TLVPrettyPrinter(const char * aFormat, ...)
+void ENFORCE_FORMAT(1, 2) TLVPrettyPrinter(const char * aFormat, ...)
{
va_list args;
