Misc clang-tidy auto fixes (#23445)
* Apply readability-redundant-control-flow,readability-redundant-string-init,readability-redundant-string-cstr on linux-x64-tests-clang
* Apply readability-redundant-control-flow,readability-redundant-string-init,readability-redundant-string-cstr on linux-x64-all-clusters-clang
* Apply readability-redundant-control-flow,readability-redundant-string-init,readability-redundant-string-cstr on linux-x64-chip-tool-clang
* Apply modernize-use-bool-literals
* apply performance-for-range-copy
* apply readability-const-return-type
* Fix compile
* Fix compile
* Added clang tidy checks as default and re-sorted the list
* Fix 2 more items found by clang-tidy during CI
* Mass-replace while(1) with while(true)
diff --git a/.clang-tidy b/.clang-tidy
index 2fa534b..580234c 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,36 +1,42 @@
---
Checks: >
- readability-else-after-return,
- modernize-use-nullptr,
bugprone-*,
- -bugprone-not-null-terminated-result,
- -bugprone-unused-return-value,
+ modernize-use-bool-literals,
+ modernize-use-nullptr,
+ performance-for-range-copy,
+ readability-const-return-type,
+ readability-else-after-return,
+ readability-redundant-control-flow,
+ readability-redundant-string-cstr,
+ readability-redundant-string-init,
-bugprone-branch-clone,
+ -bugprone-copy-constructor-init,
-bugprone-easily-swappable-parameters,
- -bugprone-reserved-identifier,
- -bugprone-macro-parentheses,
-bugprone-forward-declaration-namespace,
-bugprone-forwarding-reference-overload,
- -bugprone-undelegated-constructor,
-bugprone-implicit-widening-of-multiplication-result,
- -bugprone-narrowing-conversions,
+ -bugprone-macro-parentheses,
-bugprone-misplaced-widening-cast,
- -bugprone-suspicious-include,
+ -bugprone-narrowing-conversions,
+ -bugprone-not-null-terminated-result,
+ -bugprone-reserved-identifier,
-bugprone-signed-char-misuse,
- -bugprone-copy-constructor-init,
+ -bugprone-suspicious-include,
+ -bugprone-undelegated-constructor,
+ -bugprone-unused-return-value,
-clang-analyzer-core.CallAndMessage,
+ -clang-analyzer-core.NonNullParamChecker,
-clang-analyzer-core.NullDereference,
- -clang-analyzer-optin.cplusplus.UninitializedObject,
- -clang-analyzer-optin.performance,
- -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
- -clang-analyzer-deadcode.DeadStores,
-clang-analyzer-cplusplus.Move,
- -clang-analyzer-optin.cplusplus.VirtualCall,
- -clang-analyzer-security.insecureAPI.strcpy,
+ -clang-analyzer-deadcode.DeadStores,
-clang-analyzer-nullability.NullablePassedToNonnull,
+ -clang-analyzer-optin.cplusplus.UninitializedObject,
+ -clang-analyzer-optin.cplusplus.VirtualCall,
+ -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
+ -clang-analyzer-optin.performance,
-clang-analyzer-optin.performance.Padding,
-clang-analyzer-security.insecureAPI.rand,
- -clang-analyzer-core.NonNullParamChecker,
+ -clang-analyzer-security.insecureAPI.strcpy,
-clang-analyzer-unix.Malloc,
-clang-diagnostic-implicit-int-conversion
WarningsAsErrors: '*'
