commit 17f25a1772f7ba7535d57cd4dfa43ac1fc295843
author Amine Alami <43780877+Alami-Amine@users.noreply.github.com> Mon Sep 23 19:09:55 2024 +0200
committer GitHub <noreply@github.com> Mon Sep 23 17:09:55 2024 +0000
tree 8b96cd468f07fc759100d46f6e0699809d00ec0e
parent a99bb073006ff0a5b63833ea8f5f6d68cf42875a

Bugfix: packet buffer counter going negative and triggering UBSan Issue (#35708)

* Fix for issue where the packet buffer counter (sResourcesInUse[kSystemLayer_NumPacketBufs]) in SystemStats is going negative and underflowing, triggering a UBSan issue during fuzzing

* Integrating comments

src/system/SystemPacketBuffer.cpp

diff --git a/src/system/SystemPacketBuffer.cpp b/src/system/SystemPacketBuffer.cpp
index 20bd935..79e1bd2 100644
--- a/src/system/SystemPacketBuffer.cpp
+++ b/src/system/SystemPacketBuffer.cpp
@@ -151,6 +151,8 @@
         return;
     }
 
+    SYSTEM_STATS_INCREMENT(chip::System::Stats::kSystemLayer_NumPacketBufs);
+
     uint8_t * const newStart = newBuffer->ReserveStart();
     newBuffer->next          = nullptr;
     newBuffer->payload       = newStart + (payload - start);