tree db8a80188292b25d473cc956c2f439f334f0ce5d
parent 975eaa6b6b55fa01db2f2a8d9d5bc33a80082043
author Boris Zbarsky <bzbarsky@apple.com> 1727423361 -0400
committer GitHub <noreply@github.com> 1727423361 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJm9mOBCRC1aQ7uu5UhlAAATOgQAAOfy/G9eKnFCvleO590axwu
 OZ0I9Q6HeoSEeIxOPWbo94OhO+JeaKSIIbBLG/3xe2ihgAPrh+9iB1a4vJfNLRZR
 ciZXAXb/AqYjxGbJIR9nyfYcsY4O6IFEspX8yjZTRe71spMa7+aZq94AuJUXUbOh
 dZOYDwZFQ/gZ0LLHu3BR22/I3qK5mEZY73aZDYz+3wlZLj9liPAMybkQ07OEeAhW
 /EkPBxcPYKUQmqgmG7OEFodZY7NH62BOaFfmi3PKtE6nNXmAzpVX4LqsKrF0Nb+G
 Jj6my1woHLxGtF7DBE1QoOeST13jvln4njUqVxfyfcsc4wJkwlqAQylGO2Q7ZmHB
 +WaQ9opo70512qvBVhb6XRrd43CIG2UGjf8ACSWAk/4R90Mobn769yjPsh2vPEqN
 RyfGSIovgLOVqxENIYE2KMFu+SRtEpMPm52UWs32zOsquQVKOL9ZdAYlYznsw0cM
 Wip/u+Vg/lX3yMbqD6WSeVn+D3hntyEiX8yGsbj3kWTy0MkPEWXm6g3n0q6wzT+T
 siXCaXvsugnibs7QXxi1YDcAXQjVGnx0hx2QoclUhadN1v1c4wKtGCfl8kLB9lPq
 ZfBGU9gxhGWrne62ql+i3LaNHg82Dx/WLkd7enyfTD/ZO2tPUKxhEpzmTRa94ybz
 hB5sDA6aDN60hG/ILegr
 =nIWR
 -----END PGP SIGNATURE-----
 

Remove some more unused bits in MTRDeviceController. (#35801)

Controller's downloadLogFromNodeWithID is only used from MTRBaseDevice, which is
not expected to be used with a non-concrete controller.  Unfortunately, nothing
actually prevents an MTRBaseDevice beign created against a non-concrete
controller, so we can't just move this API to MTRDeviceController_Concrete.

With the implementation of downloadLogFromNodeWithID removed, _factory is unused
and can be removed.

Also, with this implementation removed the factory's downloadLogFromNodeWithID
can take MTRDeviceController_Concrete, as can the diagnostic log downloader.

Similarly, getSessionFromNode is only used from MTRBaseDevice and
MTRCallbackBridgeBase's ActionWithNodeID.  And ActionWithNodeID is only used
from DispatchAction, which is only called from MTRBaseClusters and
MTRBaseDevice, none of which is expected to work with a non-concrete
controller.  So this implementation can also be removed.

At that point directlyGetSessionForNode is only used from MTRDevice_Concrete,
so we can just move it to MTRDeviceController_Concrete.

getSessionForCommissioneeDevice is only used from ActionWithPASEDevice, which is
only used from DispatchAction, like getSessionFromNode.  So this implementation
can also be removed.

At this point asyncDispatchToMatterQueue is only used from:

* MTRBaseDevice
* MTRClusterStateCacheContainer, where it's used on a controller coming from
  MTRBaseDevice.
* MTRDevice_Concrete, where it's being used on a concrete controller.
* MTRDiagnosticLogsDownloader, where it's being used on a concrete controller.
* MTRServerAttribute/MTRServerCluster/MTRServerEndpoint, which are not usable
  with non-concrete controllers as things stand.
* MTROTAProviderDelegateBridge, where its being used on a concrete controller.

So the MTRDeviceController implementation of asyncDispatchToMatterQueue can also
be removed.