tree 5a3709f06b9c7b7b27be3f6336b94484e2a3e97e
parent 2410b10b3db80db6e89d89918951021b16623698
author Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> 1693250183 -0400
committer GitHub <noreply@github.com> 1693250183 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJk7PKHCRBK7hj4Ov3rIwAAMUAIAE8xWkXZUZZpZwV73/5959Zo
 N3soJE8jR/pxxi4Pvyjx3DkGh3IFlGvYq8XsgpCvPw081vRZtm3m1YkDoHWXwMk7
 tgPYc60oJKjFMg72q4C1CFhx/bIYAU2hMTj+i2GG92/3JWiMeW+JfonuyTak2XsP
 LWJZz0drACk2t5x8+M1zb4o3mtMzOfNhzeNh1DKXZ2HzhO/sVydha/v/4bnRIV5Z
 D1wAhfQ2cDRr4dSCB8xzp334myL+k50K9GuKcdc8sdTkInCrk/JO6fEsLqipBcSR
 0gTZmOKiE7kuWy5yauCZTmw8bMmjVpPXTGKjZH9wrVrf4dD7li6BijH2Q4wh1qo=
 =zVsC
 -----END PGP SIGNATURE-----
 

Remove NOCSR Request size limits and fix ReadDerLength bugs (#28899)

* Increase available size for NOCSR Request

- Some implementers ran out of space when adding even
  a single extension.
- 400 is the same size as the max compressed cert format,
  which we use many places. The total increase is thus small,
  for a transient buffer.
- ReadDerLength was private and insufficiently tested. Some issues
  were found by @bluebin14.

Testing done:
- Existing test coverage passes
- Added exhaustive unit tests for ReadDerLength, covering
  all failing cases, and expanding it usability beyond 8 bits of
  range.

* Restyled by clang-format

* Replace Max CSR size with a Min CSR size.

- Works in every situation.
- Keeps existing constant as deprecated since main legacy usage
  will still work.
- Remove a needless verification of size that was the root cause
  of issues with the constant before.

* Update src/crypto/CHIPCryptoPAL.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>