tree ea589327906e1399ff1310b8b09333f19bac73af
parent 918d3ad7b1f341e4a62f5255539c029be633359f
author Boris Zbarsky <bzbarsky@apple.com> 1671154451 -0500
committer GitHub <noreply@github.com> 1671154451 -0500
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJjm8sTCRBK7hj4Ov3rIwAAFYgIAENbYgHjMhfswAfhvGPOWKWA
 7W19Fw8M0eX2aHxWvQUwkLRxzEUBUEvgTVR0SKJCcRyDRfpAkiyMRHZppG7UPnRF
 2HhGPars4cNPl9eHqsacDlf9MV0rNpZa9xd02tRXXtDidyZ67bs6xsgc3tK2jbZS
 BbZ0JHRa42kTUmHZZ97CYzFSYnmS2hsqyomqb9kio3vc3fdA9oaTNJpkYtNPhwA5
 7jl/2qjgMB8qR8zmVrIAlAlZkQAvvfcn8BqsbFN1D2S/OAo2Nm1Pd3b8wJpjDXci
 fl13qaIuaIZeUjxCbtKPnsVUgir+YX0pOdtMzHuEwrBS01eowdYvAiGfDb4NtjM=
 =VlnZ
 -----END PGP SIGNATURE-----
 

Fix management of the mNumReportsInFlight count in reporting engine. (#24093)

If a ReadHandler failed out of SendReportData (e.g. because the session it's on
had been marked as defunct), we would increment mNumReportsInFlight and never
decrement it.  After this happened CHIP_IM_MAX_REPORTS_IN_FLIGHT times (4 by
default), we would stop being able to send out any more data reports.

This situation is pretty easy to trigger as follows:

1. Use chip-tool to commission a device with node id 17.
2. Start chip-tool interactive mode.
3. Run the following commands in interactive mode:

   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 60 17 1 --keepSubscriptions true
   onoff subscribe on-off 0 2 17 1 --keepSubscriptions true

4. quit interactive mode (Ctrl-C or quit() command).
5. Wait 60 seconds for all the subscriptions to error out.

After this the device will no longer respond with data reports to any
read or subscribe requests.