tree b31ec1ef41b947d809d08268923c29dfe0ae6fad
parent ce7d400e1c3543dc97316d26aa0a54ca1cfa76fb
author Marius Tache <102153746+marius-alex-tache@users.noreply.github.com> 1715604827 +0300
committer GitHub <noreply@github.com> 1715604827 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmQg1bCRC1aQ7uu5UhlAAAYvgQAJz4+LqjiuL2csus+abzm8zj
 9GTIykQufkvuFT6gZbDfFocaCPPtGTf0H4QnAFSq7PepsP1luKe3yLFshF3DOFEH
 gNr2FOoz8OxaKZFrjZ6tJ+4UpRcBihQZwqW9OVvfq748jzZCXMi1xWRXzIv1tu0Q
 AFzRo9r3aW5jrLxb7Sbe6MfnEaZlukfS7M3MmUSq+2U5RdaAIP8WEQefQsXY6Csk
 izu4TKreJFN0TmszjxT6EiHHJB0nY6gEGsoVzz0Hn3vzQUFMkMCNPEhz7whU3oWu
 txWuR4IBrQpd3C8GmvhlzisfqeQb7SFmPMKPS7ZefRaiz83GulIp7K1ykSlUz5u/
 3I2u3e41jHRuHXeGpwJByBdQmJxmyxIdxIdN9QPfHLyh9lM/ZgsXT3vE5hJuwqWk
 uOXQcAlreCE+xkoMBSp2enKui+9TAefBKu1xZuLEHDCwTJK/+fhUdUyqo6xCvuQi
 AElqnitZJm863i5d2+gGw2s6OpJfNV46I2TkLsJeQwE04S6oAwGwFIU2Kg5lqLFz
 V7qT24GxsauwVAn+s8ncZrm2rhVCrzkaLhwroJIqWfT9mzvVtiat7iRLy33MCZ92
 rSnIL1TlzanRzH0u1Lwug+1omaLWkLDMQ+df+Hs2OVy6tGWpsk79wIS1TXY7fI1U
 kXmQlWZWAThntLyQ5x8x
 =fdWg
 -----END PGP SIGNATURE-----
 

[K32W] Fix apply action corner case in OTATlvProcessor interface (#33214)

* [k32w] Add mShouldNotApply flag in OTATlvProcessor interface

OTATlvProcessor::ApplyAction now has a default implementation,
but derived classes are still able to overwrite this.

The flag is used by the default ApplyAction implementation.
If something goes wrong during ExitAction of the TLV processor,
then mShouldNotApply should be set to true and the image processor
should abort. In this case, the BDX transfer was already finished
and calling CancelImageUpdate will not abort the transfer, hence
the device will reboot even though it should not have. If ApplyAction
fails during HandleApply, then the process will be aborted.

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>

* [k32w0] Use mShouldNotApply flag in ExitAction

During ExitAction, set mShouldNotApply to true if an error occurs.
This ensures that the OTA will be aborted and the device does not
reboot.

Also remove the ApplyAction override, since the default implementation
is enough.

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>

* [k32w1] Use mShouldNotApply during ExitAction

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>

* [k32w] Update OTA error naming

All OTA errors should be prefixed with CHIP_ERROR.

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>

* [k32w] Replace boolean mShouldNotApply with an enum class

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>

---------

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>