tree b686b7465373746efb8291a6ba548e27e60c2d19
parent 92d87e8e412453160ce7d9c69330b3fd57d3b670
author Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> 1709668497 -0500
committer GitHub <noreply@github.com> 1709668497 -0500
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJl53iRCRC1aQ7uu5UhlAAAIFUQABSINDunG56Z33knpGhb638u
 ym71Euf4m50VJZEBUPg6CECqVVMPnCFkPgEDdTp0DUJ0tEZeYL2EUJVhz55Yt7P6
 ZChydD8zVoCRPFpiovbV1nnMBK/f6PL1yMYL8GTzuoTmT70K1zFisGUgKrX5Z/+p
 z6EzA9h55UMexTK4E3IEZcCZ3ALpJgo/NAx9zIVlQflPWi7WUqKi14wvDvPJgj/S
 IE3xZLUclzqvJyGNiKk0/Vza2/HIytTHWQnwque9wOLtD0HMsznUaKo7aWriiGuD
 vwr5NT1r+f9iDVKDTuDTSiTA+9kq2/20EKlOVIze65nisl65kMpQRqBCdPLrppf7
 98ETP3qFYYwKDvzU0SASK97r4eYXXAc+67SYQhrMcNBKlGYUz2qpngwMbkpwIjVy
 GRWnPBh8Dr0bpN7bQ+wfDNaLe56aJWqSnnA3xBjU/yfv/bMatyDawuO6saFtH3Zt
 Q4HBIkYlbRsvkznbuAKzC8LnDWwLCXy4Di9qXca+DYwVnX+oxvm6DLkCCvlOu1LI
 h6tKDyoTkutO4fJM7UDqpiB/Vq2Yu/0zcb3CzDo5nk/+ruDy8CUc533/WRvTsdaH
 Q6VYmGcLOHl+MQqiZy1zgp2BJTT3hTH5gzgQLbauA8xKfxt3cm2+p9/kb5Nkgej3
 l+r21NWNmkOvHjHoUb9A
 =2tMC
 -----END PGP SIGNATURE-----
 

Add tests to lib/support/SortUtils.h (#32421)

* Add tests to lib/support/SortUtils.h

- SortUtils.h has no tests. While it is apparently trivial,
  we should never have code that has no tests
- BubbleSort could crash (never-ending loop due to integer overflow)
  when input size was < 2. Its use is removed and replaced by InsertionSort
  which is known to be faster on average. A better solution is to move
  to using STL sorts in the future, but this requires analysis of flash
  costs and STL usage, given lambdas are used with sorts many places.

Fixes #32420

Testing done:
- Added missing unit tests.
- All integration tests still pass.

* Restyled by clang-format

* Fix build error on Android

* Add constness to operator==

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Andrei Litvin <andy314@gmail.com>