Fix casing of command fields in Window Covering cluster. (#35835)
Fixes https://github.com/project-chip/connectedhomeip/issues/30306
diff --git a/src/app/tests/suites/certification/Test_TC_WNCV_4_1.yaml b/src/app/tests/suites/certification/Test_TC_WNCV_4_1.yaml
index 2e2f29b..9a92ec9 100644
--- a/src/app/tests/suites/certification/Test_TC_WNCV_4_1.yaml
+++ b/src/app/tests/suites/certification/Test_TC_WNCV_4_1.yaml
@@ -73,7 +73,7 @@
PICS: "WNCV.S.F00 && WNCV.S.C05.Rsp"
arguments:
values:
- - name: "liftPercent100thsValue"
+ - name: "LiftPercent100thsValue"
value: 2500
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms
@@ -142,7 +142,7 @@
PICS: WNCV.S.F00 && WNCV.S.C05.Rsp
arguments:
values:
- - name: "liftPercent100thsValue"
+ - name: "LiftPercent100thsValue"
value: 7520
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms
diff --git a/src/app/tests/suites/certification/Test_TC_WNCV_4_2.yaml b/src/app/tests/suites/certification/Test_TC_WNCV_4_2.yaml
index 3290453..0ccd192 100644
--- a/src/app/tests/suites/certification/Test_TC_WNCV_4_2.yaml
+++ b/src/app/tests/suites/certification/Test_TC_WNCV_4_2.yaml
@@ -73,7 +73,7 @@
PICS: WNCV.S.F01 && WNCV.S.C08.Rsp
arguments:
values:
- - name: "tiltPercent100thsValue"
+ - name: "TiltPercent100thsValue"
value: 3000
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms
@@ -142,7 +142,7 @@
PICS: WNCV.S.F01 && WNCV.S.F04 && WNCV.S.C08.Rsp
arguments:
values:
- - name: "tiltPercent100thsValue"
+ - name: "TiltPercent100thsValue"
value: 6005
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms
diff --git a/src/app/tests/suites/certification/Test_TC_WNCV_4_3.yaml b/src/app/tests/suites/certification/Test_TC_WNCV_4_3.yaml
index 4c1260e..7f5b170 100644
--- a/src/app/tests/suites/certification/Test_TC_WNCV_4_3.yaml
+++ b/src/app/tests/suites/certification/Test_TC_WNCV_4_3.yaml
@@ -74,7 +74,7 @@
PICS: WNCV.S.F00 && WNCV.S.F02 || WNCV.S.F00 && WNCV.S.C05.Rsp
arguments:
values:
- - name: "liftPercent100thsValue"
+ - name: "LiftPercent100thsValue"
value: 0x3000
response:
error: CONSTRAINT_ERROR
@@ -86,7 +86,7 @@
PICS: WNCV.S.F00 && WNCV.S.F02 || WNCV.S.F00 && WNCV.S.C05.Rsp
arguments:
values:
- - name: "liftPercent100thsValue"
+ - name: "LiftPercent100thsValue"
value: 10001
response:
error: CONSTRAINT_ERROR
@@ -98,7 +98,7 @@
PICS: WNCV.S.F00 && WNCV.S.F02 || WNCV.S.F00 && WNCV.S.C05.Rsp
arguments:
values:
- - name: "liftPercent100thsValue"
+ - name: "LiftPercent100thsValue"
value: 0xFFFF
response:
error: CONSTRAINT_ERROR
diff --git a/src/app/tests/suites/certification/Test_TC_WNCV_4_4.yaml b/src/app/tests/suites/certification/Test_TC_WNCV_4_4.yaml
index 30d5488..9e71597 100644
--- a/src/app/tests/suites/certification/Test_TC_WNCV_4_4.yaml
+++ b/src/app/tests/suites/certification/Test_TC_WNCV_4_4.yaml
@@ -74,7 +74,7 @@
PICS: WNCV.S.F01 && WNCV.S.F04 || WNCV.S.F01 && WNCV.S.C08.Rsp
arguments:
values:
- - name: "tiltPercent100thsValue"
+ - name: "TiltPercent100thsValue"
value: 0x3000
response:
error: CONSTRAINT_ERROR
@@ -86,7 +86,7 @@
PICS: WNCV.S.F01 && WNCV.S.F04 || WNCV.S.F01 && WNCV.S.C08.Rsp
arguments:
values:
- - name: "tiltPercent100thsValue"
+ - name: "TiltPercent100thsValue"
value: 10001
response:
error: CONSTRAINT_ERROR
@@ -98,7 +98,7 @@
PICS: WNCV.S.F01 && WNCV.S.F04 || WNCV.S.F01 && WNCV.S.C08.Rsp
arguments:
values:
- - name: "tiltPercent100thsValue"
+ - name: "TiltPercent100thsValue"
value: 0xFFFF
response:
error: CONSTRAINT_ERROR
diff --git a/src/app/tests/suites/certification/Test_TC_WNCV_4_5.yaml b/src/app/tests/suites/certification/Test_TC_WNCV_4_5.yaml
index 77d959b..96d83c9 100644
--- a/src/app/tests/suites/certification/Test_TC_WNCV_4_5.yaml
+++ b/src/app/tests/suites/certification/Test_TC_WNCV_4_5.yaml
@@ -47,7 +47,7 @@
PICS: WNCV.S.F00 && WNCV.S.F02 && WNCV.S.C05.Rsp
arguments:
values:
- - name: "liftPercent100thsValue"
+ - name: "LiftPercent100thsValue"
value: 9000
#
@@ -83,7 +83,7 @@
PICS: WNCV.S.F01 && WNCV.S.F04 && WNCV.S.C08.Rsp
arguments:
values:
- - name: "tiltPercent100thsValue"
+ - name: "TiltPercent100thsValue"
value: 9000
#
diff --git a/src/app/zap-templates/zcl/data-model/chip/window-covering.xml b/src/app/zap-templates/zcl/data-model/chip/window-covering.xml
index b7224f0..0e1c97a 100644
--- a/src/app/zap-templates/zcl/data-model/chip/window-covering.xml
+++ b/src/app/zap-templates/zcl/data-model/chip/window-covering.xml
@@ -126,22 +126,22 @@
<!-- Conformance feature [LF & ABS] - for now optional -->
<command source="client" code="0x04" name="GoToLiftValue" optional="true" cli="zcl WindowCovering GoToLiftValue">
<description>Go to lift value specified</description>
- <arg name="liftValue" type="int16u"/>
+ <arg name="LiftValue" type="int16u"/>
</command>
<!-- Conformance feature LF & PA_LF | [LF] - for now optional -->
<command source="client" code="0x05" name="GoToLiftPercentage" optional="true" cli="zcl WindowCovering GoToLiftPercentage">
<description>Go to lift percentage specified</description>
- <arg name="liftPercent100thsValue" type="percent100ths"/>
+ <arg name="LiftPercent100thsValue" type="percent100ths"/>
</command>
<!-- Conformance feature [TL & ABS] - for now optional -->
<command source="client" code="0x07" name="GoToTiltValue" optional="true" cli="zcl WindowCovering GoToTiltValue">
<description>Go to tilt value specified</description>
- <arg name="tiltValue" type="int16u"/>
+ <arg name="TiltValue" type="int16u"/>
</command>
<!-- Conformance feature TL & PA_TL | [TL] - for now optional -->
<command source="client" code="0x08" name="GoToTiltPercentage" optional="true" cli="zcl WindowCovering GoToTiltPercentage">
<description>Go to tilt percentage specified</description>
- <arg name="tiltPercent100thsValue" type="percent100ths"/>
+ <arg name="TiltPercent100thsValue" type="percent100ths"/>
</command>
</cluster>