commit 6268fbbe885a07cd9adb2cb741fef2e785d1be6d
author Rohit Jadhav <69809379+jadhavrohit924@users.noreply.github.com> Mon Apr 01 12:04:07 2024 +0530
committer GitHub <noreply@github.com> Mon Apr 01 06:34:07 2024 +0000
tree 103ab63437b2e77ee208917bcc02b5fad74b84f3
parent 401fbf03731a72bae6fa9ed548de3d3aa7f72bdd

[ESP32] Fix sntp initialization (#32781)

examples/platform/esp32/time/TimeSync.cpp

diff --git a/examples/platform/esp32/time/TimeSync.cpp b/examples/platform/esp32/time/TimeSync.cpp
index e5086b8..1e688c2 100644
--- a/examples/platform/esp32/time/TimeSync.cpp
+++ b/examples/platform/esp32/time/TimeSync.cpp
@@ -22,7 +22,7 @@
 #include <lib/support/logging/CHIPLogging.h>
 
 static constexpr time_t kMinValidTimeStampEpoch = 1704067200; // 1 Jan 2019
-static constexpr uint32_t kSecondsInADay        = 24 * 60 * 60;
+static constexpr uint32_t kMilliSecondsInADay   = 24 * 60 * 60 * 1000;
 
 namespace {
 const uint8_t kMaxNtpServerStringSize = 128;
@@ -86,6 +86,11 @@
 namespace Esp32TimeSync {
 void Init(const char * aSntpServerName, const uint16_t aSyncSntpIntervalDay)
 {
+    if (!aSyncSntpIntervalDay)
+    {
+        ChipLogError(DeviceLayer, "Invalid SNTP synchronization time interval.");
+        return;
+    }
     chip::Platform::CopyString(sSntpServerName, aSntpServerName);
     if (esp_sntp_enabled())
     {
@@ -94,9 +99,9 @@
     ChipLogProgress(DeviceLayer, "Initializing SNTP. Using the SNTP server: %s", sSntpServerName);
     esp_sntp_setoperatingmode(SNTP_OPMODE_POLL);
     esp_sntp_setservername(0, sSntpServerName);
-    esp_sntp_set_sync_interval(kSecondsInADay * aSyncSntpIntervalDay);
-    esp_sntp_init();
+    esp_sntp_set_sync_interval(kMilliSecondsInADay * aSyncSntpIntervalDay);
     sntp_set_time_sync_notification_cb(TimeSyncCallback);
+    esp_sntp_init();
 }
 } // namespace Esp32TimeSync
 } // namespace chip