tree 21de89384f0f4abbd3b7b0def2ac431a91290fae
parent 4322a88b7af4c91b6ada797aa3a0f687df4723e8
author Michael Spang <spang@google.com> 1713448794 -0400
committer GitHub <noreply@github.com> 1713448794 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmISdaCRC1aQ7uu5UhlAAAhWMQAJwqad6fmcfeeuxtAxoMoa3m
 s0qwTRG5mG5ZJGXvIXJlBj76oup/H9PckKl59EO1dW1dArvpTBAHA+DOYbV86RR+
 QfodO+LZEgxYIHTURyXAGrAM3GwIynJIT36QtSalw59uEQ2Jv3wY61vsB7POAGhx
 gQXOWfcpeK1S5JJHT2ZudAoK/umrnwdYN9Plc2wYsxI8yglEK5ezqiWVjsZKcJo+
 D/wAGxhvChtKzTcR7lUNB6iqC39K9eQ1o818c6rb/C81RpyI5CHpAZ/1ctHGLtJE
 OisMx/8R43Ue+VUyniGzDH4X592BiSQ3vRJc/1bH6Eve37JjC6Chdi/c/E3/t9ir
 QNmWMxgBVeA0YYEybfq8qkwWzFAZO7A2NOmdeep9u6MOIN5asfFlK0WjyPpOvCAl
 e+3mX5tEWTZ73Snhh/1s0iMLPlPobvfqwidGn162Tg5VGZF0ZVDUu+nXvDc5ZkDb
 0ILEfxTtrYOtBXX27ZlwaAYzGaHj+uLdf2LEwvtn6LMkbFk4gOwMY2H62enIu+Cq
 LbJhW0n8p71LNHubIu75efAE+xmZxkpl2ZmE2nYTC7GWbyCuIOW3getKfTRaz15m
 YkLNME6NnaVk1aI52lYn9eKZYrJuZHwEjvnQJwdFCjRRBlOoqo9mf35BqgvHDSf1
 CKEjZQI9fXZtB/7aVF1u
 =rBho
 -----END PGP SIGNATURE-----
 

Make sure binary operators are const to fix C++20 (#33033)

Fix errors of the form

../../src/system/tests/TestSystemPacketBuffer.cpp:1063:72: error: C++20 says that these are ambiguous, even though the second is reversed: [-Werror]
 1063 |                             NL_TEST_ASSERT(inSuite, config_1.handle == original_handle_1);
      |                                                                        ^~~~~~~~~~~~~~~~~
../../third_party/nlunit-test/repo/src/nlunit-test.h:366:15: note: in definition of macro ‘NL_TEST_ASSERT’
  366 |         if (!(inCondition))                             \
      |               ^~~~~~~~~~~
../../src/system/SystemPacketBuffer.h:690:10: note: candidate 1: ‘bool chip::System::PacketBufferHandle::operator==(const chip::System::PacketBufferHandle&)’
  690 |     bool operator==(const PacketBufferHandle & aOther) { return mBuffer == aOther.mBuffer; }
      |          ^~~~~~~~
../../src/system/SystemPacketBuffer.h:690:10: note: candidate 2: ‘bool chip::System::PacketBufferHandle::operator==(const chip::System::PacketBufferHandle&)’ (reversed)
../../src/system/SystemPacketBuffer.h:690:10: note: try making the operator a ‘const’ member function

when compiling with cpp_standard="gnu++20" by making sure comparators
are const members.