commit 8bc3888e5c402b7e58d552328291b760de9100b6
author lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Mon Sep 23 18:30:52 2024 -0400
committer GitHub <noreply@github.com> Mon Sep 23 22:30:52 2024 +0000
tree 070bf5fadd7835bded31e62225ab8fc718c846fe
parent 1597be7bf723656bfdc1d8b84a4240773e9d1a03

Removed attribute-type.h from attribute-metadata and moved definitions inside of .cpp file (#35731)

src/app/util/attribute-metadata.cpp

diff --git a/src/app/util/attribute-metadata.cpp b/src/app/util/attribute-metadata.cpp
index bf649a9..749ef16 100644
--- a/src/app/util/attribute-metadata.cpp
+++ b/src/app/util/attribute-metadata.cpp
@@ -18,6 +18,16 @@
 
 #include <app-common/zap-generated/attribute-type.h>
 
+bool EmberAfAttributeMetadata::IsBoolean() const
+{
+    return attributeType == ZCL_BOOLEAN_ATTRIBUTE_TYPE;
+}
+
+bool EmberAfAttributeMetadata::IsSignedIntegerAttribute() const
+{
+    return chip::app::IsSignedAttributeType(attributeType);
+}
+
 bool emberAfIsStringAttributeType(EmberAfAttributeType attributeType)
 {
     return (attributeType == ZCL_OCTET_STRING_ATTRIBUTE_TYPE || attributeType == ZCL_CHAR_STRING_ATTRIBUTE_TYPE);

src/app/util/attribute-metadata.h

diff --git a/src/app/util/attribute-metadata.h b/src/app/util/attribute-metadata.h
index 5be6916..6703e39 100644
--- a/src/app/util/attribute-metadata.h
+++ b/src/app/util/attribute-metadata.h
@@ -17,7 +17,6 @@
 
 #pragma once
 
-#include <app-common/zap-generated/attribute-type.h>
 #include <app/util/basic-types.h>
 #include <cstdint>
 
@@ -161,12 +160,12 @@
     /**
      * Check wether this attribute is a boolean based on its type according to the spec.
      */
-    bool IsBoolean() const { return attributeType == ZCL_BOOLEAN_ATTRIBUTE_TYPE; }
+    bool IsBoolean() const;
 
     /**
      * Check wether this attribute is signed based on its type according to the spec.
      */
-    bool IsSignedIntegerAttribute() const { return chip::app::IsSignedAttributeType(attributeType); }
+    bool IsSignedIntegerAttribute() const;
 
     /**
      * Check whether this attribute has a define min and max.