tree fceca313a1a3286bdb32dbd280c97e38dbfb11dd
parent ecd0f6f8c75966ecdf1f444360565a287f58f455
author Boris Zbarsky <bzbarsky@apple.com> 1686759318 -0400
committer GitHub <noreply@github.com> 1686759318 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJkieeWCRBK7hj4Ov3rIwAAZEQIAGrTfuFLaoBanpBz0DkTXYW4
 3P6qZSWcF3YW04B2HrIhzNMBcnUbpUfbI4QJc6Dv7+ZxD91wlxrKMn56ukI/F0iz
 qZVeXyioETc6SAmmrHfV1KDi8Gp9VqnuKcymOgG7dUkm84xYPM6fKIAugolv3mY4
 ND5LNIj+FC2C5KmwZplxP8+scOTLQ9gnrvLb3nhjKDtMvd/YNEaKJd89B83Z9Ckp
 Qz4S8orf9YPhfmnnTwsb9hXZOh4e9N1wcR37+NBMPR1P/CwksueLb2BEAXHE03Mt
 ocOroLL0Uswrd16xGZiJCNqx9whTDLtiL/lWxxbV02FctKoQ5aw7cy6+ubMGB5U=
 =PCeJ
 -----END PGP SIGNATURE-----
 

Do proper ACL checks on event reads/subscriptions. (#26761)

* Do proper ACL checks on event reads/subscriptions.

This adds the following functionality:

1. We now correctly detect subsciptions that don't have any access to anything,
   even if they have an event path in the subscribe request.  For paths with a
   wildcard event id, this check assumes read privileges are needed when event
   lists are disabled, and uses the actual event-specific privileges when event
   lists are enabled.
2. When doing reads of an unsupported event, correctly return an
   errors instead of an empty event list.
3. Fix various unit test mocks to provide the information needed for the new
   checks.
4. Update expectation in existing YAML test that was checking an "unimplemented
   event" case.

* Address review comments.

* Fix darwin build.

* Fix Darwin tests, now that we get errors for unsupported events.

* Move function declarations to a non-codegen-dependent header.

* Handle ACL checks for event wildcards even if we have no EventList.

* Update to spec change for unsupported event errors.

* Address review comments.