commit a0c00a1c13cf48d58cc9098ab01b6729669ee5f8
author Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> Tue Apr 08 17:37:08 2025 -0400
committer GitHub <noreply@github.com> Tue Apr 08 21:37:08 2025 +0000
tree 823eefb8fca5062227258d5f6ef1676aa6b375bd
parent 625d0e7c2376c8ef4e6b0b85afb5c1e40b8df577

Fix unit test static analyzer warning (#38304)

Error was:
```
../../src/crypto/tests/TestChipCryptoPAL.cpp:1573:38: note: Access of 'csr' at negative byte offset -2
 1573 |         csr[length - 2] = (uint8_t) (csr[length - 2] + 1);
      |                                      ^~~~~~~~~~~~~~~

WARNING TIDY ../../src/crypto/tests/TestChipCryptoPAL.cpp: 1 warning treated as error
WARNING Tidy ../../src/crypto/tests/TestChipCryptoPAL.cpp ended with code 1
```

Cause was that a EXPECT was used where ASSERT should be used, which leads to
an access in mbedTLS unit test version, that should not have run.

src/crypto/tests/TestChipCryptoPAL.cpp

diff --git a/src/crypto/tests/TestChipCryptoPAL.cpp b/src/crypto/tests/TestChipCryptoPAL.cpp
index 1713b3c..beaae3e 100644
--- a/src/crypto/tests/TestChipCryptoPAL.cpp
+++ b/src/crypto/tests/TestChipCryptoPAL.cpp
@@ -1558,14 +1558,14 @@
 
     Test_P256Keypair keypair;
     EXPECT_EQ(keypair.Initialize(ECPKeyTarget::ECDSA), CHIP_NO_ERROR);
-    EXPECT_EQ(keypair.NewCertificateSigningRequest(csr, length), CHIP_NO_ERROR);
-    EXPECT_GT(length, 0u);
+    ASSERT_EQ(keypair.NewCertificateSigningRequest(csr, length), CHIP_NO_ERROR);
+    ASSERT_GT(length, 2u);
 
     P256PublicKey pubkey;
     CHIP_ERROR err = VerifyCertificateSigningRequest(csr, length, pubkey);
     if (err != CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE)
     {
-        EXPECT_EQ(err, CHIP_NO_ERROR);
+        ASSERT_EQ(err, CHIP_NO_ERROR);
         EXPECT_EQ(pubkey.Length(), kP256_PublicKey_Length);
         EXPECT_EQ(memcmp(pubkey.ConstBytes(), keypair.Pubkey().ConstBytes(), pubkey.Length()), 0);