Make in RAM NetworkCommissioning::Featuremap report kThreadDevice (#14751)
* Switch default 'Network Commissioning'::'FeatureMap' attribute to 2
This makes the default in-ram setting claim 'I am a thread device'.
This is because most wifi devices already support a spec-compliant
network cluster:
- linux reports as wifi
- esp32 reports as wifi
- darwin has an intentional 'report as 0' for unit tests which needs
to be altered and ZAP defaults will not apply anyway.
Found files to be changed and validated via:
fd 'zap$' | xargs rg 'Network Commissioning' | cut -f1 -d: | uniq | xargs -n1 jq '.endpointTypes[].clusters[] | select(.name == "Network Commissioning") | {name: .name, attr: .attributes[] | {name:.name, default:.defaultValue, file: input_filename}} | select(.attr.name == "FeatureMap" and .attr.default != "2")'
* Ran zap regen
* Disable features on network configuration cluster on EP1. Not sure why we have 2 of them, likely they do not work
* Ran zap regendiff --git a/zzz_generated/bridge-app/zap-generated/endpoint_config.h b/zzz_generated/bridge-app/zap-generated/endpoint_config.h
index 553e450..c3cf9d5 100644
--- a/zzz_generated/bridge-app/zap-generated/endpoint_config.h
+++ b/zzz_generated/bridge-app/zap-generated/endpoint_config.h
@@ -54,7 +54,7 @@
0x00, 0x00, 0x00, 0x00, \
\
/* 38 - FeatureMap, */ \
- 0x00, 0x00, 0x00, 0x01, \
+ 0x00, 0x00, 0x00, 0x02, \
\
/* Endpoint: 0, Cluster: General Diagnostics (server), big-endian */ \
\
@@ -321,7 +321,7 @@
0x00, 0x00, 0x00, 0x00, \
\
/* 38 - FeatureMap, */ \
- 0x01, 0x00, 0x00, 0x00, \
+ 0x02, 0x00, 0x00, 0x00, \
\
/* Endpoint: 0, Cluster: General Diagnostics (server), little-endian */ \
\
