commit ad57f01eef92dd8e5b46c8d07d7e23f3c5f46504
author mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> Fri Oct 04 08:46:33 2024 -0400
committer GitHub <noreply@github.com> Fri Oct 04 12:46:33 2024 +0000
tree f4128351d5b2cec5756ca19db7065509eda85bab
parent 33b1f2294a17b65de98bda508945be2daa9adf33

Fix empty report feedback loop (#35899)

src/app/reporting/ReportScheduler.h

diff --git a/src/app/reporting/ReportScheduler.h b/src/app/reporting/ReportScheduler.h
index f0e6ce3..d6425e3 100644
--- a/src/app/reporting/ReportScheduler.h
+++ b/src/app/reporting/ReportScheduler.h
@@ -150,6 +150,7 @@
                      IsEngineRunScheduled()));
         }
 
+        bool CanStartReporting() const { return mReadHandler->CanStartReporting(); }
         bool IsChunkedReport() const { return mReadHandler->IsChunkedReport(); }
         bool IsEngineRunScheduled() const { return mFlags.Has(ReadHandlerNodeFlags::EngineRunScheduled); }
         void SetEngineRunScheduled(bool aEngineRunScheduled)

src/app/reporting/SynchronizedReportSchedulerImpl.cpp

diff --git a/src/app/reporting/SynchronizedReportSchedulerImpl.cpp b/src/app/reporting/SynchronizedReportSchedulerImpl.cpp
index a402f32..6d04e2b 100644
--- a/src/app/reporting/SynchronizedReportSchedulerImpl.cpp
+++ b/src/app/reporting/SynchronizedReportSchedulerImpl.cpp
@@ -183,7 +183,7 @@
     VerifyOrReturn(mNodesPool.Allocated());
 
     mNodesPool.ForEachActiveObject([now, &firedEarly](ReadHandlerNode * node) {
-        if (node->GetMinTimestamp() <= now)
+        if (node->GetMinTimestamp() <= now && node->CanStartReporting())
         {
             // Since this handler can now report whenever it wants to, mark it as allowed to report if any other handler is
             // reporting using the CanBeSynced flag.