commit b79831ed9324fa5c89f5200b026b83f6605e4b91
author Boris Zbarsky <bzbarsky@apple.com> Tue Apr 02 18:06:20 2024 -0400
committer GitHub <noreply@github.com> Tue Apr 02 22:06:20 2024 +0000
tree c678435806bb05f3867a9a758ed7be317f4d8fc4
parent ff2ab2b9617e15fd783e7088c3917e3d1f0681d2

Don't stringify PeerAddress in SendPreparedMessage if not logging it. (#32821)

src/transport/SessionManager.cpp

diff --git a/src/transport/SessionManager.cpp b/src/transport/SessionManager.cpp
index dfcbd60..b821820 100644
--- a/src/transport/SessionManager.cpp
+++ b/src/transport/SessionManager.cpp
@@ -448,10 +448,10 @@
     {
         CHIP_ERROR err = mTransportMgr->SendMessage(*destination, std::move(msgBuf));
 #if CHIP_ERROR_LOGGING
-        char addressStr[Transport::PeerAddress::kMaxToStringSize] = { 0 };
-        destination->ToString(addressStr);
         if (err != CHIP_NO_ERROR)
         {
+            char addressStr[Transport::PeerAddress::kMaxToStringSize] = { 0 };
+            destination->ToString(addressStr);
             ChipLogError(Inet, "SendMessage() to %s failed: %" CHIP_ERROR_FORMAT, addressStr, err.Format());
         }
 #endif // CHIP_ERROR_LOGGING