tree 4d328e71576ce5d2d53a8622645b6a7f371ff92e
parent e0720983ada1019b6b59073c78883f91ee9fc3b0
author Boris Zbarsky <bzbarsky@apple.com> 1668447575 -0500
committer GitHub <noreply@github.com> 1668447575 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJjcn1XCRBK7hj4Ov3rIwAA8Q0IADLiLqyIeXwR/M0yrFXe6Xg4
 dBaZ1yFfaG7yVN+WBAsZzIDtV0vgDaHcubHxV7ykUEwb0OzPJfJ3UxgcKzIXZYQQ
 kRaYlkHREE96FWVHkPNO/ZCQx6kocUgNvC7R3LZzLBo611xhDx28PK9+l2YgZtD/
 Z32GcVRbDNII6QJaJH9K0inAb09JixB7a66XmrO8RAD011xG7Izg7bPIXNCo4HQD
 27g8aNF38WXDtG0GNifC8vmBvS9KnqSuChJ80GzUOYOeCjEwfe4UXG1ezas4FhMs
 U7Yx7jsgvF6WTRmwuzX6jR9EBxRd1l1pHz5CHZWFW9XgcJ3O51vPlEdUQLPh8Hs=
 =YhRg
 -----END PGP SIGNATURE-----
 

Avoid double-delete when a Darwin subscribeAttribute subscription errors out. (#23557)

* Avoid double-delete when a Darwin subscribeAttribute subscription errors out.

Right now Darwin subscribeAttribute subscriptions do not support turning off auto-resubscribe, so never error out.  But if we were to add that, we would end up with double delete: once when the error happens, and once from OnDone.

This fix:

1) Ensures that we don't flag callback bridges as mKeepAlive until we have
   successfully sent a subscribe request.
2) Stops deleting on error if mKeepAlive is true.
3) Ensures the delete of the bridge from OnDone does not happen until after
   we have finished using the bridge object (e.g. to handle already-queued data
   or error notifications).  We do this by queueing the delete to the same
   dispatch queue as the data/error notifications.

* Address review comment.