tree 0fc314887e65b3f7aa11b94db3e225326bcc0238
parent 9eb2e29f8b2b95dafbbfd06de733c44e136e8195
author Andrei Litvin <andy314@gmail.com> 1714411957 -0400
committer GitHub <noreply@github.com> 1714411957 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmL9m1CRC1aQ7uu5UhlAAAK94QAIeo34dR6EVg+DcugaDWhD+R
 NiyP9MYoYKNBS5hFjcfRMM90CjtR3ikvN3BVA7MaG5JL10/95CQYg82M9cobQrmC
 OWfz5ie6xc+TyoC+VDEwiHne8r/qtDbnOTDaSgocVCmzM1sx/GR1lTCvRBz5wAEl
 agaLyavFcKF1CCP2WoFfYQRB/tZJM1ZxgtomXHLNdy+PpwUAkaLYAn45C2hLsgyb
 5o4xF6jaEgMuyX9C3CUBZ1tXBgWQB+oIBmx3oMIk5JurNEMIDk6YNlkHxpLy9f9u
 NLXSnNHbu8UzTj7HMUPppLL4f3orisxkePtX7YqLiWmYyJ1XKlu9wG+pfCdN/Rzk
 GgmZqZ3FAWCqvjj7dtzXDT1kl17G2hxznDKxVpPWYWVMpJ+XiyhZe08CbhRueRVV
 WiC3mnuwqFJOquHYmkfBVj2mUolSsiZifuTRSKVRPXNqQJNYlFcW8BEfg3fgpI3n
 KraxpezrnsD3cT5ZXMaQSKexzcbuKNz1L3K5c1gy0GRIQAPXp8REq11EKTp75YHZ
 h0ZlJKQw5ad9nmFc0c39ZN2fhkp8lHGi5W2PxrtI/fG6J0LGDVYEg64ytUWatlCJ
 RVI0KeaD7UEv/PB912zUcJY+AHfpIcpCAVbAVNAVQQvbgE8bMNqTLHY6UC23TCsn
 vmKeBfK6YloYt2pBSYk5
 =yIv5
 -----END PGP SIGNATURE-----
 

Use std::optional for chip::Nullable (#33080)

* make nullable depend on std::optional instead of chip::optional

* Fix equality operator

* Fix inequality operator as well

* Fix test: previous code was enforcing chip::optional behavior on in-place construction

* Restyle

* Fix some compile errors ... std::optional now detects unused variables

* Restyle

* Remove unused variable

* Restyle

* Review updates

* Review fix

* Typo fixes

* Ugly forward of Value and ValueOr .... however at least hopefully it is complete

* Do not expose value/value_or at this time and keep Value/ValueOr as the public API for nullable

* Fix copy and paste typo

* Make more changes to make things compile and work like the old nullable

* Use value again instead of operator** ... I was looking at the wrong compiler errors

* Undo unrelated change

* Make clang-tidy be abel to compile ... apparently it really does not like using has_value in equality operators

* Restyle

* Another update to make clang-tidy happy for the other equality operator

* Update src/app/data-model/Nullable.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Undo odd whitespace change

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>