commit e5b79ae413c1f77c7277dac686812ad0c29a4651
author Boris Zbarsky <bzbarsky@apple.com> Mon Sep 30 18:19:36 2024 -0400
committer GitHub <noreply@github.com> Mon Sep 30 22:19:36 2024 +0000
tree 057c7229b1dc06c03b6edec1c7272a8457872e7d
parent 41ca3295f96d1e4d054813c6586b833f9346913b

Improve DataVersion filter list logging when subscribing. (#35850)

We logged the encoded filters when doing a re-subscribe with a
ClusterStateCache, but not when doing an initial subscribe.  This moves the
logging into the encoding of the filter list, so it's logged consistently.

Also logs the DataVersion that we get back in MTRDevice_Concrete.

src/app/ClusterStateCache.cpp

diff --git a/src/app/ClusterStateCache.cpp b/src/app/ClusterStateCache.cpp
index 65ab120..fdb8e40 100644
--- a/src/app/ClusterStateCache.cpp
+++ b/src/app/ClusterStateCache.cpp
@@ -626,15 +626,7 @@
             continue;
         }
 
-        DataVersionFilterIB::Builder & filterIB = aDataVersionFilterIBsBuilder.CreateDataVersionFilter();
-        SuccessOrExit(err = aDataVersionFilterIBsBuilder.GetError());
-        ClusterPathIB::Builder & filterPath = filterIB.CreatePath();
-        SuccessOrExit(err = filterIB.GetError());
-        SuccessOrExit(err = filterPath.Endpoint(filter.first.mEndpointId).Cluster(filter.first.mClusterId).EndOfClusterPathIB());
-        SuccessOrExit(err = filterIB.DataVersion(filter.first.mDataVersion.Value()).EndOfDataVersionFilterIB());
-        ChipLogProgress(DataManagement, "Update DataVersionFilter: Endpoint=%u Cluster=" ChipLogFormatMEI " Version=%" PRIu32,
-                        filter.first.mEndpointId, ChipLogValueMEI(filter.first.mClusterId), filter.first.mDataVersion.Value());
-
+        SuccessOrExit(err = aDataVersionFilterIBsBuilder.EncodeDataVersionFilterIB(filter.first));
         aEncodedDataVersionList = true;
     }