tree 606807086374c9585d437d0704ecf82fca532a07
parent 60568988053e5ea32a2e3091fb1d9c32e548c47a
author Boris Zbarsky <bzbarsky@apple.com> 1659986847 -0400
committer GitHub <noreply@github.com> 1659986847 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJi8WOfCRBK7hj4Ov3rIwAAm3kIAE3CbCuLl/LHqkP1Eyun6+j+
 0tbTUUX3bsKsiM/nASZ1D++Jv9uq9VNj0KSW2Cajhyi3PI3ndsWX/f4eUNmVnUVF
 YfhKxN4OZHpfle9/vWts7khv1Hl832cHr/F52RvmBOJRVoE1jkl7oJWo0DCkBnZt
 Gu8tKySkiFNk+LZrx8Vx0hsMzuNyOXMMbPj3d5H64DjM1RCgQleWTh7rgFsoTW99
 8cpbrXewANPL3zqjwRGZHEPaFXtval6PIfdlyxg/C0763cXzt2DuX+8Pcq+oXKTY
 K5uLZDyFuFiUnekBFdtc7F/2zVz2CRSTwBBoDFFDT623lfkvlEuwES4LRInQE78=
 =mRIE
 -----END PGP SIGNATURE-----
 

Fix TC_CADMIN_1_9 and TC_CADMIN_1_10 tests to not be broken. (#21690)

There were several issues:

* The values of the "payload" variable were mixed up between the two tests.  as
  a result, "payload" actually had an incorrect setup code in both tests, and
  the tests testing that commissioning fails actually tested nothing at all,
  because it was guaranteed to fail.

* Some of the setup payloads involved claimed a zero discovery capability
  bitmask, instead of the expected "bit 2 is set to indicate on-network
  commissioning".  This led to a lot of BLE traffic when these tests run.

The specific fixes here are:

1) In TC_CADMIN_1_9, regenerate the "payload" value by running:

      chip-tool payload generate-qrcode --vendor-id 65521 --product-id 32769 --discriminator 3840 --rendezvous 4 --setup-pin-code 47514138

   and regenerate "payload2" by running:

      chip-tool payload generate-qrcode --vendor-id 65521 --product-id 32769 --discriminator 3840 --rendezvous 4 --setup-pin-code 20202023

   This ensures that the only difference between "payload" and "payload2" is the
   setup code, and sets the setup code for "payload" to match the verifier we
   are using.

2) In TC_CADMIN_1_10, regenerate the "payload" value by running:

       chip-tool payload generate-qrcode --vendor-id 65521 --product-id 32769 --discriminator 3840 --rendezvous 4 --setup-pin-code 20202021

   and regenerate "payload2" by running:

      chip-tool payload generate-qrcode --vendor-id 65521 --product-id 32769 --discriminator 3840 --rendezvous 4 --setup-pin-code 20202023

3) In both tests, add verification that the "payload" value can in fact
   commission the device properly when a commissioning window is opened the way
   the test opens it, so the rest of the test is meaningful.

4) Rename "payload" and "payload2" to more meaningful names.