commit edb93a03ef06682c6c7b2c1e8fd33e352c06b0b0
author Vivien Nicolas <vnicolas@apple.com> Thu Sep 22 23:18:06 2022 +0200
committer GitHub <noreply@github.com> Thu Sep 22 17:18:06 2022 -0400
tree a4177088c25cc87ef328ce71ee3d00cba2f43cd5
parent c74b7f8e6ae8cd28ca83d83e471dc74a10b61dda

[Darwin] Call ResetSharedConnection and not StartSharedConnection in src/platform/Darwin/DnssdHostNameRegistrar.cpp in order to properly unregister / register interfaces addresses (#22810)

src/platform/Darwin/DnssdHostNameRegistrar.cpp

diff --git a/src/platform/Darwin/DnssdHostNameRegistrar.cpp b/src/platform/Darwin/DnssdHostNameRegistrar.cpp
index a936521..a241579 100644
--- a/src/platform/Darwin/DnssdHostNameRegistrar.cpp
+++ b/src/platform/Darwin/DnssdHostNameRegistrar.cpp
@@ -272,7 +272,7 @@
     VerifyOrReturnError(!IsLocalOnly(), CHIP_NO_ERROR);
 
     return StartMonitorInterfaces(^(InetInterfacesVector inetInterfaces, Inet6InterfacesVector inet6Interfaces) {
-        ReturnOnFailure(StartSharedConnection());
+        ReturnOnFailure(ResetSharedConnection());
         RegisterInterfaces(inetInterfaces, kDNSServiceType_A);
         RegisterInterfaces(inet6Interfaces, kDNSServiceType_AAAA);
     });
@@ -355,6 +355,8 @@
 
 CHIP_ERROR HostNameRegistrar::StartSharedConnection()
 {
+    VerifyOrReturnError(mServiceRef == nullptr, CHIP_ERROR_INCORRECT_STATE);
+
     auto err = DNSServiceCreateConnection(&mServiceRef);
     VerifyOrReturnValue(kDNSServiceErr_NoError == err, Error::ToChipError(err));