tree fcec13f3401625295c94b872b41f027ad5167445
parent 7ddf8be557aafd69195c69cd8de5bcc012756f04
author Kevin Schoedel <67607049+kpschoedel@users.noreply.github.com> 1624309728 -0400
committer GitHub <noreply@github.com> 1624309728 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJg0P/gCRBK7hj4Ov3rIwAAwfkIAFm3g5sZQqiVMsFjkIGKJQWW
 8h1ODujfsiiynPfL9HTLKrpO2tTQcMnKGCE14+aYB8bJcnEaSxctR/9LB/mk6ZlC
 l4qPyJfnlgxs2V60y8R7RVMVoBZ+erp5D9BCB9THtLBtRe2itCOR9x7xmjgAzXni
 hzsVrApvuJxF6amuARB4jpJQV+HhE8w/sJyLMbSjPybwoG8W8MhGHLszScTZIH+Z
 cKQ7dKDbJo7lFyGPOitKMClsKdNvX1UGPAzc7AF7gVNomwPXBJ5xHu4iI2+er0Kd
 gjl2IWdNZONPiVYnB3TSCjfIZDi07z8goywAPdGSrurvcuhjgVUYLfUT6+Una7E=
 =ItxK
 -----END PGP SIGNATURE-----
 

Remove `exit: return` idiom from some directories (#7768)

#### Problem

The `Exit` group of error-handling macros inhibit scoping, and
are unnecessary when there is no cleanup at the `exit:` label.

Part of #7721 _goto exit pattern should be replaced with RAII in C++_

#### Change overview

Remove simple `exit: return` from
  * `src/app`
  * `src/controller`
  * `src/crypto`
  * `src/inet`
  * `src/lib`
  * `src/protocols`
  * `src/setup_payload`
  * `src/transport`
replacing `Exit` macros with corresponding `Return` macros.

Note that this does not change any `exit:` blocks with actual cleanup.

#### Testing

No change to functionality; existing tests should catch regressions.