tree f04a15c571d488c067a0e6027cbb2db1fd2acc40
parent fe9a8ec2f4d383ea244300ffb9953de32e952492
author Boris Zbarsky <bzbarsky@apple.com> 1667999377 -0500
committer GitHub <noreply@github.com> 1667999377 -0500
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJja6aRCRBK7hj4Ov3rIwAA3AMIABd6mYzTmdSyqVnew7wAymKh
 VXaOJIxfNMb9L5ZrGDfqp7qvQ/EvgwKdsYRQHZRNpv27io/IoFVDphl36pX3m3MB
 k/wAWmM5GSj5axiADJDkm2htyjFelcUKYeDIstf7gYeTcLBz6g0oW0Nt4kjbYqMg
 SXIWBSb+Cj0XzFWfeaJUeCr06fgukPN8Q0KhYSM2V2a91rnZ4UZmPhqlMzN5gohg
 Abf8wAFFayg8BgTmgAhbDizZOHKE8reOGzQKG4ZQFdAfr6UD/DVIHHDDofcGtOOI
 PI9o4yCmnsQ7ABxmbI+p/DXMEl8Km8ODdYHVGUMBFTLFvdhvVnOGITfWsY8kLBg=
 =OYE/
 -----END PGP SIGNATURE-----
 

Address API review issues in MTRDeviceController. (#23512)

This is a re-landing of PR #22596 but with changes made for backwards compat.

* Make MTRBaseDevice creation synchronous.  This requires updates to
  MTRBaseDeviceOverXPC to do the possible async getting of the controller id it
  needs during its async operations, not when getting the device object.
* Deprecate pairDevice methods.
* Rename "commissionDevice" to "commissionNodeWithID".
* Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document.
* Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID".
* Various documentation improvements.
* Fix signature of computePaseVerifier.

The header changes not accompanied by backwards-compat shims are OK for the
following reasons:

* In MTRDeviceController.h, the change to isRunning is binary and source
  compatible.
* MTRDeviceControllerOverXPC_Internal.h is not public API.
* MTRDeviceController_Internal.h is not public API.
* MTRDeviceOverXPC.h is not public API.
* The changes to MTRSetupPayload.h are backward-compatible.