commit 048f5c26a783f5f92061aec3aab19986e5c8d435
author Benjamin Barenblat <benjamin@barenblat.name> Wed Jul 11 13:20:01 2018 -0400
committer Thomas Van Lenten <thomasvl@google.com> Wed Jul 11 13:20:01 2018 -0400
tree 74fe45ea33ccb4ae295f5359d875ac345db8d837
parent 237938ac6ae07d732e1147073ab3569379c313a5

objectivec: Quash -Wself-assign and -Wvla (#4897)

* objectivec: Quash -Wself-assign

* objectivec: Set -Wno-vla when building

Objective-C protobuf uses VLAs for performance reasons. Ensure Clang
doesn’t complain about them.

BUILD

diff --git a/BUILD b/BUILD
index 7f7ec75..df9867b 100644
--- a/BUILD
+++ b/BUILD
@@ -934,6 +934,9 @@
 objc_library(
     name = "objectivec",
     hdrs = OBJC_HDRS + OBJC_PRIVATE_HDRS,
+    copts = [
+        "-Wno-vla",
+    ],
     includes = [
         "objectivec",
     ],

objectivec/Tests/GPBTestUtilities.m

diff --git a/objectivec/Tests/GPBTestUtilities.m b/objectivec/Tests/GPBTestUtilities.m
index ebccaac..0362bdd 100644
--- a/objectivec/Tests/GPBTestUtilities.m
+++ b/objectivec/Tests/GPBTestUtilities.m
@@ -85,7 +85,7 @@
   NSLog(@"Wrote data file to %@", path);
 #else
   // Kill off the unused variable warning.
-  dataToWrite = dataToWrite;
+  (void)dataToWrite;
 #endif
   return data;
 }