commit 0ea9685deb63106e66a9da388d1d25f8ff5f671d
author Mark Hansen <markhansen@google.com> Thu Sep 26 19:16:33 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Sep 26 19:19:41 2024 -0700
tree 5f3c6d0325ba4406a1e6dd2d62868521a8219cde
parent 01f94be00d234b74c6d00f10552ceff6450d89da

Use an explicit locale when formatting OutOfSpaceException.

Implicitly using the default locale is a common source of bugs:
https://developer.android.com/reference/java/util/Locale.html#default_locale

PiperOrigin-RevId: 679381814

java/core/src/main/java/com/google/protobuf/CodedOutputStream.java

diff --git a/java/core/src/main/java/com/google/protobuf/CodedOutputStream.java b/java/core/src/main/java/com/google/protobuf/CodedOutputStream.java
index 22a4aa4..342fdd9 100644
--- a/java/core/src/main/java/com/google/protobuf/CodedOutputStream.java
+++ b/java/core/src/main/java/com/google/protobuf/CodedOutputStream.java
@@ -19,6 +19,7 @@
 import java.nio.BufferOverflowException;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
+import java.util.Locale;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -962,7 +963,7 @@
     }
 
     OutOfSpaceException(long position, long limit, int length, Throwable cause) {
-      this(String.format("Pos: %d, limit: %d, len: %d", position, limit, length), cause);
+      this(String.format(Locale.US, "Pos: %d, limit: %d, len: %d", position, limit, length), cause);
     }
   }
 
@@ -1168,8 +1169,11 @@
       if ((offset | length | (buffer.length - (offset + length))) < 0) {
         throw new IllegalArgumentException(
             String.format(
+                Locale.US,
                 "Array range is invalid. Buffer.length=%d, offset=%d, length=%d",
-                buffer.length, offset, length));
+                buffer.length,
+                offset,
+                length));
       }
       this.buffer = buffer;
       this.offset = offset;