Fix integer truncation and missing NULL checks in upb (#27712) ## Summary Four hardening fixes for upb internals found during security audit: 1. **compare_unknown.c:122-126 — integer truncation + missing NULL check**: `oldsize` and `newsize` are declared as `int` but hold `size_t * sizeof(...)` products. On 64-bit systems, these truncate to 32 bits, causing incorrect `upb_grealloc` arguments at large field counts (~89.5M unknown fields). Also adds missing NULL check after `upb_grealloc`, using the existing `upb_UnknownFields_OutOfMemory()` longjmp handler. 2. **map_sorter.h/map_sorter.c — same integer truncation pattern**: `_upb_mapsorter` struct fields (`size`, `cap`) and `_upb_sortedmap` fields (`start`, `pos`, `end`) are `int` despite `_upb_Map_Size()` returning `size_t`. Same truncation overflow as #1. 3. **copy.c:41 — missing NULL check before memcpy**: `upb_Clone_StringView` calls `upb_Arena_Malloc` then `memcpy` without checking for NULL. The parallel code path in `upb_Clone_MessageValue` (same file, line 67-69) correctly checks. 4. **array.h:83 — missing overflow check in array allocation**: `_upb_Array_NewMaybeAllowSlow` computes `init_capacity << elem_size_lg2` without overflow guard. The parallel `_upb_Array_Realloc` (`array.c:169-180`) uses `upb_ShlOverflow()`. The combined check `init_capacity > (SIZE_MAX - array_size) >> elem_size_lg2` guards against both shift overflow and the subsequent addition overflow. ## Test plan - [x] Add `ManyFieldsSortReallocation` test for compare_unknown.c sort buffer reallocation - [x] Add `ManyFieldsNotEqual` test verifying differing values detected after sorting - [x] Add `NewOverflowCapacityReturnsNull` test for array.h overflow guard - [ ] Existing unit tests pass 🔒 Found during security audit of upb internals Closes #27712 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/27712 from jortles:fix-upb-integer-null-hardening 6cbc9ae985655bde93ba4c3d09d14537d77e4142 PiperOrigin-RevId: 999523263
Copyright 2008 Google LLC
Protocol Buffers (a.k.a., protobuf) are Google's language-neutral, platform-neutral, extensible mechanism for serializing structured data. You can learn more about it in protobuf's documentation.
This README file contains protobuf installation instructions. To install protobuf, you need to install the protocol compiler (used to compile .proto files) and the protobuf runtime for your chosen programming language.
Most users will find working from supported releases to be the easiest path.
If you choose to work from the head revision of the main branch your build will occasionally be broken by source-incompatible changes and insufficiently-tested (and therefore broken) behavior.
If you are using C++ or otherwise need to build protobuf from source as a part of your project, you should pin to a release commit on a release branch.
This is because even release branches can experience some instability in between release commits.
Protobuf supports Bzlmod with Bazel 8 +. Users should specify a dependency on protobuf in their MODULE.bazel file as follows.
bazel_dep(name = "protobuf", version = <VERSION>)
Users can optionally override the repo name, such as for compatibility with WORKSPACE.
bazel_dep(name = "protobuf", version = <VERSION>, repo_name = "com_google_protobuf")
Users can also add the following to their legacy WORKSPACE file.
Note that with the release of 30.x there are a few more load statements to properly set up rules_java and rules_python.
http_archive(
name = "com_google_protobuf",
strip_prefix = "protobuf-VERSION",
sha256 = ...,
url = ...,
)
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
protobuf_deps()
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
rules_java_dependencies()
load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
rules_java_toolchains()
load("@rules_python//python:repositories.bzl", "py_repositories")
py_repositories()
The protobuf compiler is written in C++. If you are using C++, please follow the C++ Installation Instructions to install protoc along with the C++ runtime.
For non-C++ users, the simplest way to install the protocol compiler is to download a pre-built binary from our GitHub release page.
In the downloads section of each release, you can find pre-built binaries in zip packages: protoc-$VERSION-$PLATFORM.zip. It contains the protoc binary as well as a set of standard .proto files distributed along with protobuf.
If you are looking for an old version that is not available in the release page, check out the Maven repository.
These pre-built binaries are only provided for released versions. If you want to use the github main version at HEAD, or you need to modify protobuf code, or you are using C++, it's recommended to build your own protoc binary from source.
If you would like to build protoc binary from source, see the C++ Installation Instructions.
Protobuf supports several different programming languages. For each programming language, you can find instructions in the corresponding source directory about how to install protobuf runtime for that specific language:
| Language | Source |
|---|---|
| C++ (include C++ runtime and protoc) | src |
| Java | java |
| Python | python |
| Objective-C | objectivec |
| C# | csharp |
| Ruby | ruby |
| Go | protocolbuffers/protobuf-go |
| PHP | php |
| Dart | dart-lang/protobuf |
| JavaScript | protocolbuffers/protobuf-javascript |
The best way to learn how to use protobuf is to follow the tutorials in our developer guide.
If you want to learn from code examples, take a look at the examples in the examples directory.
The complete documentation is available at the Protocol Buffers doc site.
Read about our version support policy to stay current on support timeframes for the language libraries.
To be alerted to upcoming changes in Protocol Buffers and connect with protobuf developers and users, join the Google Group.