[editors/emacs] Fix protobuf-mode definition (#9572)

Fix a few issues with the Emacs mode definition.

First, in 1ab7789f3 (2021-10-13, Emacs: Protobuf mode should be derived from
prog-mode) we made `protobuf-mode' a derived mode of `prog-mode' using the
`define-derived-mode' macro[1]. However, the definition body was not updated
accordingly. So in this commit, we:

- Remove the superfluous `(interactive)' form;
- Remove the unnecessary call of `kill-all-local-variables', which is already
  handled by `define-derived-mode' and could cause a few issues, for example,
  it prevents `prog-mode-hook' from being run;
- Remove forms that set `major-mode' and `mode-name', which are automatically
  set to the first and third arguments respectively;
- Remove forms that set key map, syntax table, and abbrev table, which are
  already handled automatically;
- Do not run `protobuf-mode-hook' explicitly in the body. It is already arranged
  to be run after the body.

Second, the call to `c-make-emacs-variables-local' is removed. It is called
inside `c-init-language-vars' already. Calling it again should do no harm now,
but to be future-proof it might be better to just remove it.

Finally, we move the `c-update-modeline' form to the :after-hook argument to
ensure it is run at the very end, so that the mode line will reflect all user
customizations done in various mode hooks. Similarly, we run
`c-mode-common-hook' also at the very end to leave a place for user
customizations (for example, set `imenu-generic-expression' in
`c-mode-common-hook').

[1] https://www.gnu.org/software/emacs/manual/html_node/elisp/Derived-Modes.html

Re: https://github.com/protocolbuffers/protobuf/issues/7316
Re: https://github.com/protocolbuffers/protobuf/pull/9076
1 file changed
tree: 46013a20ae872bec24ccc03ccc15f454aa0e7972
  1. .github/
  2. benchmarks/
  3. cmake/
  4. conformance/
  5. csharp/
  6. docs/
  7. editors/
  8. examples/
  9. java/
  10. js/
  11. kokoro/
  12. m4/
  13. objectivec/
  14. php/
  15. protoc-artifacts/
  16. python/
  17. ruby/
  18. src/
  19. third_party/
  20. toolchain/
  21. util/
  22. .bazelignore
  23. .gitignore
  24. .gitmodules
  25. .readthedocs.yml
  26. appveyor.bat
  27. appveyor.yml
  28. autogen.sh
  29. BUILD
  30. build_files_updated_unittest.sh
  31. cc_proto_blacklist_test.bzl
  32. CHANGES.txt
  33. compiler_config_setting.bzl
  34. composer.json
  35. configure.ac
  36. CONTRIBUTING.md
  37. CONTRIBUTORS.txt
  38. fix_permissions.sh
  39. generate_changelog.py
  40. generate_descriptor_proto.sh
  41. global.json
  42. internal.bzl
  43. LICENSE
  44. Makefile.am
  45. maven_install.json
  46. post_process_dist.sh
  47. Protobuf-C++.podspec
  48. protobuf-lite.pc.in
  49. protobuf.bzl
  50. protobuf.pc.in
  51. Protobuf.podspec
  52. protobuf_deps.bzl
  53. protobuf_release.bzl
  54. protobuf_version.bzl
  55. README.md
  56. SECURITY.md
  57. tests.sh
  58. update_compatibility_version.py
  59. update_file_lists.sh
  60. update_version.py
  61. WORKSPACE
README.md

Protocol Buffers - Google's data interchange format

Copyright 2008 Google Inc.

https://developers.google.com/protocol-buffers/

Overview

Protocol Buffers (a.k.a., protobuf) are Google's language-neutral, platform-neutral, extensible mechanism for serializing structured data. You can find protobuf's documentation on the Google Developers site.

This README file contains protobuf installation instructions. To install protobuf, you need to install the protocol compiler (used to compile .proto files) and the protobuf runtime for your chosen programming language.

Protocol Compiler Installation

The protocol compiler is written in C++. If you are using C++, please follow the C++ Installation Instructions to install protoc along with the C++ runtime.

For non-C++ users, the simplest way to install the protocol compiler is to download a pre-built binary from our release page:

https://github.com/protocolbuffers/protobuf/releases

In the downloads section of each release, you can find pre-built binaries in zip packages: protoc-$VERSION-$PLATFORM.zip. It contains the protoc binary as well as a set of standard .proto files distributed along with protobuf.

If you are looking for an old version that is not available in the release page, check out the maven repo here:

https://repo1.maven.org/maven2/com/google/protobuf/protoc/

These pre-built binaries are only provided for released versions. If you want to use the github master version at HEAD, or you need to modify protobuf code, or you are using C++, it's recommended to build your own protoc binary from source.

If you would like to build protoc binary from source, see the C++ Installation Instructions.

Protobuf Runtime Installation

Protobuf supports several different programming languages. For each programming language, you can find instructions in the corresponding source directory about how to install protobuf runtime for that specific language:

LanguageSource
C++ (include C++ runtime and protoc)src
Javajava
Pythonpython
Objective-Cobjectivec
C#csharp
JavaScriptjs
Rubyruby
Goprotocolbuffers/protobuf-go
PHPphp
Dartdart-lang/protobuf

Quick Start

The best way to learn how to use protobuf is to follow the tutorials in our developer guide:

https://developers.google.com/protocol-buffers/docs/tutorials

If you want to learn from code examples, take a look at the examples in the examples directory.

Documentation

The complete documentation for Protocol Buffers is available via the web at:

https://developers.google.com/protocol-buffers/