tree bf5385406d2e938e5fc86636b78c836bfa30cd98
parent 5752b2d07b6b57c78a01f6113e3858c490c3aee0
author Tony Liao <tonyliaoss@google.com> 1732736524 -0800
committer Copybara-Service <copybara-worker@google.com> 1732736804 -0800

Print better error message when registering an extension with a duplicate number.

Before, the upb_ExtensionRegistry_AddArray API would just return a boolean
indicating whether the operation succeeded or failed. This is not descriptive
enough in some cases and made the error output confusing.

Specifically, when trying to register an extension with a duplicate extension
number, AddArray first performs a map lookup before inserting the extension
entry into the registry. The code handled lookup failure (due to duplicates)
the same way as insertion failure (due to OOM), and printed an error message
that showed OOM when there is a duplicate array entry.

This was acknolwedged in a TODO in the AddArray code comment -- which is now
fixed. :)

PiperOrigin-RevId: 700764584