commit 7d978084ca28ac8a456dbdd9d6b39e6dfc169fd9
author Hiroshi Ichikawa <gimite@gmail.com> Tue May 01 00:44:41 2018 +0900
committer Thomas Van Lenten <thomasvl@google.com> Mon Apr 30 11:44:41 2018 -0400
tree 3b994554a1a82a27396b61eef5e2e1f4dcb5676e
parent fc922d16ed7ae3c19defe82228a9760f3d8d1073

[objectivec] Fix memory leak of exceptions raised by RaiseException() (#4556)

* Fix memory leak of exceptions raised by RaiseException()

Currently exceptions raised by RaiseException() is never deallocated because:

* ARC is disabled for this library: https://github.com/google/protobuf/blob/master/BUILD#L913
* It is constructed with `+alloc` but is never `-release`d.

This change fixes the issue by using `-[NSException exceptionWithName:...]` instead, which returns an autoreleased instance, so it is deallocated properly.

* Fix format.

objectivec/GPBCodedInputStream.m

diff --git a/objectivec/GPBCodedInputStream.m b/objectivec/GPBCodedInputStream.m
index a8262e5..dd05ddb 100644
--- a/objectivec/GPBCodedInputStream.m
+++ b/objectivec/GPBCodedInputStream.m
@@ -63,9 +63,9 @@
 
   NSDictionary *exceptionInfo =
       @{ GPBCodedInputStreamUnderlyingErrorKey: error };
-  [[[NSException alloc] initWithName:GPBCodedInputStreamException
-                              reason:reason
-                            userInfo:exceptionInfo] raise];
+  [[NSException exceptionWithName:GPBCodedInputStreamException
+                           reason:reason
+                         userInfo:exceptionInfo] raise];
 }
 
 static void CheckRecursionLimit(GPBCodedInputStreamState *state) {