commit 94a1819c7ae8509ab6ad37d867d3ea60a5809aaa
author Sam Saccone <samccone@gmail.com> Sun Jan 13 18:25:16 2019 -0800
committer Paul Yang <TeBoring@users.noreply.github.com> Sun Jan 13 18:25:16 2019 -0800
tree 26ad01dfab82847426da1be39f1d9e223fe2f88e
parent a2a0afb5468dc423782344a2047abc041e75323e

Remove unused f expression from jscode gen. (#5573)

Varadic assignment in javascript where the right hand expression is an
object yields a single set assignment with the right most lefthand variable,
while leaving the other left side expressions undefined.

For example:
var a,b = {}

will only initialize a to undefined. But will set b to the {} value.

--

For this code since f is never used, it is a safe operation to remove
it.

src/google/protobuf/compiler/js/js_generator.cc

diff --git a/src/google/protobuf/compiler/js/js_generator.cc b/src/google/protobuf/compiler/js/js_generator.cc
index fd0367b..71e9ba8 100644
--- a/src/google/protobuf/compiler/js/js_generator.cc
+++ b/src/google/protobuf/compiler/js/js_generator.cc
@@ -2272,7 +2272,7 @@
       " * @suppress {unusedLocalVariables} f is only used for nested messages\n"
       " */\n"
       "$classname$.toObject = function(includeInstance, msg) {\n"
-      "  var f, obj = {",
+      "  var obj = {",
       "classname", GetMessagePath(options, desc));
 
   bool first = true;