commit 953adb16ff2f982d54dd812b51df5fdb392732f8
author Thomas Van Lenten <thomasvl@google.com> Wed Jan 31 11:59:57 2018 -0500
committer Thomas Van Lenten <thomasvl@google.com> Wed Jan 31 12:36:54 2018 -0500
tree f6a855939173eaf8a5a4d6bfc84a87fff8255a0e
parent b718551571983f281d065e818da4fd9ca5723d89

Add casts to removed undefined behaviors around shifts.

Fixes #4246
Fixes #4247

objectivec/GPBUtilities.m

diff --git a/objectivec/GPBUtilities.m b/objectivec/GPBUtilities.m
index 77ea957..2574656 100644
--- a/objectivec/GPBUtilities.m
+++ b/objectivec/GPBUtilities.m
@@ -291,7 +291,7 @@
   } else {
     NSCAssert(idx != GPBNoHasBit, @"Invalid has bit.");
     uint32_t byteIndex = idx / 32;
-    uint32_t bitMask = (1 << (idx % 32));
+    uint32_t bitMask = (1U << (idx % 32));
     BOOL hasIvar =
         (self->messageStorage_->_has_storage_[byteIndex] & bitMask) ? YES : NO;
     return hasIvar;
@@ -315,7 +315,7 @@
     NSCAssert(idx != GPBNoHasBit, @"Invalid has bit.");
     uint32_t *has_storage = self->messageStorage_->_has_storage_;
     uint32_t byte = idx / 32;
-    uint32_t bitMask = (1 << (idx % 32));
+    uint32_t bitMask = (1U << (idx % 32));
     if (value) {
       has_storage[byte] |= bitMask;
     } else {