Fix usage of six in //:protobuf_python rule and add import (#6310) * Fix reference to six in //:protobuf_python rule * Add six to protobuf_deps.bzl * Use six archive directly as repo @six
diff --git a/BUILD b/BUILD index 6665de9..93b948c 100644 --- a/BUILD +++ b/BUILD
@@ -911,7 +911,7 @@ py_extra_srcs = glob(["python/**/__init__.py"]), py_libs = [ ":python_srcs", - "//external:six", + "@six//:six", ], srcs_version = "PY2AND3", visibility = ["//visibility:public"],
diff --git a/WORKSPACE b/WORKSPACE index 3687680..ee505d1 100644 --- a/WORKSPACE +++ b/WORKSPACE
@@ -13,7 +13,7 @@ ) http_archive( - name = "six_archive", + name = "six", build_file = "@//:six.BUILD", sha256 = "105f8d68616f8248e24bf0e9372ef04d3cc10104f1980f54d57b2ce73a5ad56a", urls = ["https://pypi.python.org/packages/source/s/six/six-1.10.0.tar.gz#md5=34eed507548117b2ab523ab14b2f8b55"], @@ -41,11 +41,6 @@ actual = "@submodule_gmock//:gtest_main", ) -bind( - name = "six", - actual = "@six_archive//:six", -) - maven_jar( name = "guava_maven", artifact = "com.google.guava:guava:18.0",
diff --git a/protobuf_deps.bzl b/protobuf_deps.bzl index 25fad72..eb6610e 100644 --- a/protobuf_deps.bzl +++ b/protobuf_deps.bzl
@@ -13,3 +13,11 @@ strip_prefix = "zlib-1.2.11", urls = ["https://zlib.net/zlib-1.2.11.tar.gz"], ) + + if "six" not in native.existing_rules(): + http_archive( + name = "six", + build_file = "@//:six.BUILD", + sha256 = "105f8d68616f8248e24bf0e9372ef04d3cc10104f1980f54d57b2ce73a5ad56a", + urls = ["https://pypi.python.org/packages/source/s/six/six-1.10.0.tar.gz#md5=34eed507548117b2ab523ab14b2f8b55"], + )