commit e26ef8683e5176b73938ed9d086d67bb6bd5be10
author Protobuf Team Bot <protobuf-github-bot@google.com> Mon Aug 26 05:14:52 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Aug 26 05:32:33 2024 -0700
tree 0d6457b57c3efb60ba785ae676ae93752e43af4e
parent 86dab71245ade3f2c8e46ac642489fd70f6a81b3

Cleanup pass on where we use Private and doc(hidden)

We were really inconsistent on where we put Private or not and this tries to make a sensible consistent state of:

- For types that are exposed to application code, any pub methods which are only pub so they can be used by gencode (which is mostly anything that has any internal/runtime type anywhere on the parameters or return type list), have those methods have both a `Private` arg and doc(hidden)

- For structs that are only inside __runtime / __internal to begin with, put doc(hidden) on the types, and don't put Private on any of their methods since callers can't reach those types regardless.

Note that for exposed functions which also _accept_ another internal/runtime type in a parameter, the additional `Private` arg is superfluous since application code shouldn't ever be able to reach one of those internal types to be able to pass one in, but this keeps the pattern of keeping Private on it in those cases as well (the `Private` would still be the only guard on methods which only _return_ an internal type).

PiperOrigin-RevId: 667547566