fix(upb): guard array, map reserve, and extension registry against size/shift overflow (#30787) ## Summary This PR adds overflow and shift-bounds checks across `upb/message` and `upb/mini_table/extension_registry.c`: 1. **`_upb_Array_NewMaybeAllowSlow` and `_upb_Array_TryFastRealloc` (`upb/message/internal/array.h`)**: - In `_upb_Array_NewMaybeAllowSlow`, `const size_t elem_bytes = init_capacity << elem_size_lg2;` and the arena pool lookup previously ran *before* checking whether `init_capacity` overflows `size_t` when shifted by `elem_size_lg2`. If `init_capacity = (SIZE_MAX >> elem_size_lg2) + 1` and a 16-byte recycled pool block is present on the arena, `elem_bytes` wraps to `0`, `pool_bytes` becomes `16`, and `_upb_Array_New` returns a non-`NULL` under-sized array (`capacity = 16 >> elem_size_lg2`, e.g. `2` for 8-byte elements) instead of failing with `NULL`. Move and tighten the `init_capacity` upper-bound check (`init_capacity > (max_bytes - array_size) >> elem_size_lg2`) before the shift and pool lookup. - In `_upb_Array_TryFastRealloc`, guard `capacity > max_bytes >> elem_size_lg2` before `capacity << elem_size_lg2`. 2. **`upb_Array_Insert` (`upb/message/array.c`)**: - `upb_Array_Insert` checked `upb_AddOverflow(arr->UPB_PRIVATE(size), count, &new_size)` only via `UPB_ASSERT(ok)`, which is compiled out under `NDEBUG`. In release builds on a non-empty array, `upb_Array_Insert(arr, 0, SIZE_MAX, arena)` wraps `new_size` below `arr->UPB_PRIVATE(size)`, passes `_upb_Array_ResizeUninitialized`, and calls `upb_Array_Move` with `i + count` out of bounds. Return `false` when `!ok` (matching `upb_Array_AppendAll`). 3. **`_upb_Map_Reserve` (`upb/message/map.c`)**: - Guard against `size` addition overflow and `size_lg2 >= 32` before evaluating `(size_t)1 << size_lg2` (which triggers undefined shift behavior when `size_lg2 >= sizeof(size_t) * CHAR_BIT`). 4. **`upb_ExtensionRegistry_AddArray` (`upb/mini_table/extension_registry.c`) and `_upb_Message_Copy` (`upb/message/copy.c`)**: - Guard `count * sizeof(*e)` and pointer addition wraparound in `upb_ExtensionRegistry_AddArray` before `UPB_PTRADD(e, count)`. - Guard `mini_table->UPB_PRIVATE(size) < sizeof(upb_Message)` before subtracting `sizeof(upb_Message)` in `_upb_Message_Copy`. ## Test Plan - Added `MessageTest.ArrayMapAndExtensionRegistryOverflow` in `upb/message/test.cc` covering `_upb_Array_New` with a seeded 16-byte arena pool block, `_upb_Array_TryFastRealloc`, `upb_Array_Insert` (`NDEBUG`), `upb_Map_Reserve`, and `upb_ExtensionRegistry_AddArray`. - Verified with Bazel 8.6.0 and clang 21.1.8 on Linux x86_64: `bazel test //upb/...` (48 test targets) passes under `-c opt`, the default fastbuild configuration, and `--config=asan --config=ubsan`, with `//upb/message:test` run 3 times in each. On unpatched `main` the new test fails in all three configurations. Related: the `_upb_Array_NewMaybeAllowSlow` bound builds on the check added by #27712. That check runs only on the pool-miss path, after `elem_bytes = init_capacity << elem_size_lg2` has already been computed and used for the pool lookup; this change moves the same bound ahead of the shift and the pool lookup and also reserves `UPB_MALLOC_ALIGN - 1` and the ASan guard size. The other sites (`upb_Array_Insert`, `_upb_Array_TryFastRealloc`, `_upb_Map_Reserve`, `upb_ExtensionRegistry_AddArray`, `_upb_Message_Copy`) are not touched by #27712 or by the earlier `_upb_Array_Realloc` PRs (#26373, #26534, #27568). Closes #30787 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/30787 from professor-moody:fix-upb-array-map-extreg-overflow-guards 5c6cb3354601b6b1433abba09944ecaaffae6aa6 FUTURE_COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/30787 from professor-moody:fix-upb-array-map-extreg-overflow-guards 5c6cb3354601b6b1433abba09944ecaaffae6aa6 PiperOrigin-RevId: 1014041046
Copyright 2008 Google LLC
Protocol Buffers (a.k.a., protobuf) are Google's language-neutral, platform-neutral, extensible mechanism for serializing structured data. You can learn more about it in protobuf's documentation.
This README file contains protobuf installation instructions. To install protobuf, you need to install the protocol compiler (used to compile .proto files) and the protobuf runtime for your chosen programming language.
Most users will find working from supported releases to be the easiest path.
If you choose to work from the head revision of the main branch your build will occasionally be broken by source-incompatible changes and insufficiently-tested (and therefore broken) behavior.
If you are using C++ or otherwise need to build protobuf from source as a part of your project, you should pin to a release commit on a release branch.
This is because even release branches can experience some instability in between release commits.
Protobuf supports Bzlmod with Bazel 8 +. Users should specify a dependency on protobuf in their MODULE.bazel file as follows.
bazel_dep(name = "protobuf", version = <VERSION>)
Users can optionally override the repo name, such as for compatibility with WORKSPACE.
bazel_dep(name = "protobuf", version = <VERSION>, repo_name = "com_google_protobuf")
Users can also add the following to their legacy WORKSPACE file.
Note that with the release of 30.x there are a few more load statements to properly set up rules_java and rules_python.
http_archive(
name = "com_google_protobuf",
strip_prefix = "protobuf-VERSION",
sha256 = ...,
url = ...,
)
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
protobuf_deps()
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
rules_java_dependencies()
load("@rules_java//java:repositories.bzl", "rules_java_toolchains")
rules_java_toolchains()
load("@rules_python//python:repositories.bzl", "py_repositories")
py_repositories()
The protobuf compiler is written in C++. If you are using C++, please follow the C++ Installation Instructions to install protoc along with the C++ runtime.
For non-C++ users, the simplest way to install the protocol compiler is to download a pre-built binary from our GitHub release page.
In the downloads section of each release, you can find pre-built binaries in zip packages: protoc-$VERSION-$PLATFORM.zip. It contains the protoc binary as well as a set of standard .proto files distributed along with protobuf.
If you are looking for an old version that is not available in the release page, check out the Maven repository.
These pre-built binaries are only provided for released versions. If you want to use the github main version at HEAD, or you need to modify protobuf code, or you are using C++, it's recommended to build your own protoc binary from source.
If you would like to build protoc binary from source, see the C++ Installation Instructions.
Protobuf supports several different programming languages. For each programming language, you can find instructions in the corresponding source directory about how to install protobuf runtime for that specific language:
| Language | Source |
|---|---|
| C++ (include C++ runtime and protoc) | src |
| Java | java |
| Python | python |
| Objective-C | objectivec |
| C# | csharp |
| Ruby | ruby |
| Go | protocolbuffers/protobuf-go |
| PHP | php |
| Dart | dart-lang/protobuf |
| JavaScript | protocolbuffers/protobuf-javascript |
The best way to learn how to use protobuf is to follow the tutorials in our developer guide.
If you want to learn from code examples, take a look at the examples in the examples directory.
The complete documentation is available at the Protocol Buffers doc site.
Read about our version support policy to stay current on support timeframes for the language libraries.
To be alerted to upcoming changes in Protocol Buffers and connect with protobuf developers and users, join the Google Group.